-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Closed
Labels
Area-IDEBugLSPissues related to the roslyn language server protocol implementationissues related to the roslyn language server protocol implementationPerformance-Scenario-DiagnosticsThis issue affects diagnostics computation performance for lightbulb, background analysis, tagger.This issue affects diagnostics computation performance for lightbulb, background analysis, tagger.untriagedIssues and PRs which have not yet been triaged by a leadIssues and PRs which have not yet been triaged by a lead
Description
Currently, neither of these handlers consider the below background analysis scope options for disabling compiler and/or analyzer diagnostics:
roslyn/src/Features/LanguageServer/Protocol/Features/Options/SolutionCrawlerOptionsStorage.cs
Lines 13 to 17 in bdbf1cb
| /// <summary> | |
| /// Option to turn configure background analysis scope for the current user. | |
| /// </summary> | |
| public static readonly PerLanguageOption2<BackgroundAnalysisScope> BackgroundAnalysisScopeOption = new( | |
| "dotnet_solution_crawler_background_analysis_scope", defaultValue: BackgroundAnalysisScope.Default, serializer: EditorConfigValueSerializer.CreateSerializerForEnum<BackgroundAnalysisScope>()); |
As this is not just a functionality issue, but also affects performance (unnecessarily running analyzers that users don't wish to see diagnostics for), we should prioritize fixing it.
Metadata
Metadata
Assignees
Labels
Area-IDEBugLSPissues related to the roslyn language server protocol implementationissues related to the roslyn language server protocol implementationPerformance-Scenario-DiagnosticsThis issue affects diagnostics computation performance for lightbulb, background analysis, tagger.This issue affects diagnostics computation performance for lightbulb, background analysis, tagger.untriagedIssues and PRs which have not yet been triaged by a leadIssues and PRs which have not yet been triaged by a lead