Long switch expression is duplicated in InferTypesWorker_DoNotCallDirectly overloads

[Youssef1313]

roslyn/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/LanguageServices/CSharpTypeInferenceService.TypeInferrer.cs

Lines 141 to 193 in 975dcc5

	return parent switch
	{
	AnonymousObjectMemberDeclaratorSyntax memberDeclarator => InferTypeInMemberDeclarator(memberDeclarator),
	ArgumentSyntax argument => InferTypeInArgument(argument),
	ArrayCreationExpressionSyntax arrayCreationExpression => InferTypeInArrayCreationExpression(arrayCreationExpression),
	ArrayRankSpecifierSyntax arrayRankSpecifier => InferTypeInArrayRankSpecifier(arrayRankSpecifier),
	ArrayTypeSyntax arrayType => InferTypeInArrayType(arrayType),
	ArrowExpressionClauseSyntax arrowClause => InferTypeInArrowExpressionClause(arrowClause),
	AssignmentExpressionSyntax assignmentExpression => InferTypeInBinaryOrAssignmentExpression(assignmentExpression, assignmentExpression.OperatorToken, assignmentExpression.Left, assignmentExpression.Right, expression),
	AttributeArgumentSyntax attribute => InferTypeInAttributeArgument(attribute),
	AttributeSyntax _ => InferTypeInAttribute(),
	AwaitExpressionSyntax awaitExpression => InferTypeInAwaitExpression(awaitExpression),
	BinaryExpressionSyntax binaryExpression => InferTypeInBinaryOrAssignmentExpression(binaryExpression, binaryExpression.OperatorToken, binaryExpression.Left, binaryExpression.Right, expression),
	CastExpressionSyntax castExpression => InferTypeInCastExpression(castExpression, expression),
	CatchDeclarationSyntax catchDeclaration => InferTypeInCatchDeclaration(catchDeclaration),
	CatchFilterClauseSyntax catchFilterClause => InferTypeInCatchFilterClause(catchFilterClause),
	CheckedExpressionSyntax checkedExpression => InferTypes(checkedExpression),
	ConditionalAccessExpressionSyntax conditionalAccessExpression => InferTypeInConditionalAccessExpression(conditionalAccessExpression),
	ConditionalExpressionSyntax conditionalExpression => InferTypeInConditionalExpression(conditionalExpression, expression),
	ConstantPatternSyntax constantPattern => InferTypeInConstantPattern(constantPattern),
	DoStatementSyntax doStatement => InferTypeInDoStatement(doStatement),
	EqualsValueClauseSyntax equalsValue => InferTypeInEqualsValueClause(equalsValue),
	ExpressionColonSyntax expressionColon => InferTypeInExpressionColon(expressionColon),
	ExpressionStatementSyntax _ => InferTypeInExpressionStatement(),
	ForEachStatementSyntax forEachStatement => InferTypeInForEachStatement(forEachStatement, expression),
	ForStatementSyntax forStatement => InferTypeInForStatement(forStatement, expression),
	IfStatementSyntax ifStatement => InferTypeInIfStatement(ifStatement),
	InitializerExpressionSyntax initializerExpression => InferTypeInInitializerExpression(initializerExpression, expression),
	IsPatternExpressionSyntax isPatternExpression => InferTypeInIsPatternExpression(isPatternExpression, node),
	LockStatementSyntax lockStatement => InferTypeInLockStatement(lockStatement),
	MemberAccessExpressionSyntax memberAccessExpression => InferTypeInMemberAccessExpression(memberAccessExpression, expression),
	NameColonSyntax nameColon => InferTypeInNameColon(nameColon),
	NameEqualsSyntax nameEquals => InferTypeInNameEquals(nameEquals),
	LambdaExpressionSyntax lambdaExpression => InferTypeInLambdaExpression(lambdaExpression),
	PostfixUnaryExpressionSyntax postfixUnary => InferTypeInPostfixUnaryExpression(postfixUnary),
	PrefixUnaryExpressionSyntax prefixUnary => InferTypeInPrefixUnaryExpression(prefixUnary),
	RecursivePatternSyntax propertyPattern => InferTypeInRecursivePattern(propertyPattern),
	PropertyPatternClauseSyntax propertySubpattern => InferTypeInPropertyPatternClause(propertySubpattern),
	RefExpressionSyntax refExpression => InferTypeInRefExpression(refExpression),
	ReturnStatementSyntax returnStatement => InferTypeForReturnStatement(returnStatement),
	SubpatternSyntax subpattern => InferTypeInSubpattern(subpattern, node),
	SwitchExpressionArmSyntax arm => InferTypeInSwitchExpressionArm(arm),
	SwitchLabelSyntax switchLabel => InferTypeInSwitchLabel(switchLabel),
	SwitchStatementSyntax switchStatement => InferTypeInSwitchStatement(switchStatement),
	ThrowExpressionSyntax throwExpression => InferTypeInThrowExpression(throwExpression),
	ThrowStatementSyntax throwStatement => InferTypeInThrowStatement(throwStatement),
	UsingStatementSyntax usingStatement => InferTypeInUsingStatement(usingStatement),
	WhenClauseSyntax whenClause => InferTypeInWhenClause(whenClause),
	WhileStatementSyntax whileStatement => InferTypeInWhileStatement(whileStatement),
	YieldStatementSyntax yieldStatement => InferTypeInYieldStatement(yieldStatement),
	_ => SpecializedCollections.EmptyEnumerable<TypeInferenceInfo>(),
	};
	}

roslyn/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/LanguageServices/CSharpTypeInferenceService.TypeInferrer.cs

Lines 203 to 258 in 975dcc5

	return parent switch
	{
	AnonymousObjectCreationExpressionSyntax anonymousObjectCreation => InferTypeInAnonymousObjectCreation(anonymousObjectCreation, token),
	AnonymousObjectMemberDeclaratorSyntax memberDeclarator => InferTypeInMemberDeclarator(memberDeclarator, token),
	ArgumentListSyntax argument => InferTypeInArgumentList(argument, token),
	ArgumentSyntax argument => InferTypeInArgument(argument, token),
	ArrayCreationExpressionSyntax arrayCreationExpression => InferTypeInArrayCreationExpression(arrayCreationExpression, token),
	ArrayRankSpecifierSyntax arrayRankSpecifier => InferTypeInArrayRankSpecifier(arrayRankSpecifier, token),
	ArrayTypeSyntax arrayType => InferTypeInArrayType(arrayType, token),
	ArrowExpressionClauseSyntax arrowClause => InferTypeInArrowExpressionClause(arrowClause),
	AssignmentExpressionSyntax assignmentExpression => InferTypeInBinaryOrAssignmentExpression(assignmentExpression, assignmentExpression.OperatorToken, assignmentExpression.Left, assignmentExpression.Right, previousToken: token),
	AttributeArgumentListSyntax attributeArgumentList => InferTypeInAttributeArgumentList(attributeArgumentList, token),
	AttributeArgumentSyntax argument => InferTypeInAttributeArgument(argument, token),
	AttributeListSyntax attributeDeclaration => InferTypeInAttributeDeclaration(attributeDeclaration, token),
	AttributeTargetSpecifierSyntax attributeTargetSpecifier => InferTypeInAttributeTargetSpecifier(attributeTargetSpecifier, token),
	AwaitExpressionSyntax awaitExpression => InferTypeInAwaitExpression(awaitExpression, token),
	BinaryExpressionSyntax binaryExpression => InferTypeInBinaryOrAssignmentExpression(binaryExpression, binaryExpression.OperatorToken, binaryExpression.Left, binaryExpression.Right, previousToken: token),
	BinaryPatternSyntax binaryPattern => GetPatternTypes(binaryPattern),
	BracketedArgumentListSyntax bracketedArgumentList => InferTypeInBracketedArgumentList(bracketedArgumentList, token),
	CastExpressionSyntax castExpression => InferTypeInCastExpression(castExpression, previousToken: token),
	CatchDeclarationSyntax catchDeclaration => InferTypeInCatchDeclaration(catchDeclaration, token),
	CatchFilterClauseSyntax catchFilterClause => InferTypeInCatchFilterClause(catchFilterClause, token),
	CheckedExpressionSyntax checkedExpression => InferTypes(checkedExpression),
	ConditionalExpressionSyntax conditionalExpression => InferTypeInConditionalExpression(conditionalExpression, previousToken: token),
	DefaultExpressionSyntax defaultExpression => InferTypeInDefaultExpression(defaultExpression),
	DoStatementSyntax doStatement => InferTypeInDoStatement(doStatement, token),
	EqualsValueClauseSyntax equalsValue => InferTypeInEqualsValueClause(equalsValue, token),
	ExpressionColonSyntax expressionColon => InferTypeInExpressionColon(expressionColon, token),
	ExpressionStatementSyntax _ => InferTypeInExpressionStatement(token),
	ForEachStatementSyntax forEachStatement => InferTypeInForEachStatement(forEachStatement, previousToken: token),
	ForStatementSyntax forStatement => InferTypeInForStatement(forStatement, previousToken: token),
	IfStatementSyntax ifStatement => InferTypeInIfStatement(ifStatement, token),
	ImplicitArrayCreationExpressionSyntax implicitArray => InferTypeInImplicitArrayCreation(implicitArray),
	InitializerExpressionSyntax initializerExpression => InferTypeInInitializerExpression(initializerExpression, previousToken: token),
	LockStatementSyntax lockStatement => InferTypeInLockStatement(lockStatement, token),
	MemberAccessExpressionSyntax memberAccessExpression => InferTypeInMemberAccessExpression(memberAccessExpression, previousToken: token),
	NameColonSyntax nameColon => InferTypeInNameColon(nameColon, token),
	NameEqualsSyntax nameEquals => InferTypeInNameEquals(nameEquals, token),
	BaseObjectCreationExpressionSyntax objectCreation => InferTypeInObjectCreationExpression(objectCreation, token),
	LambdaExpressionSyntax lambdaExpression => InferTypeInLambdaExpression(lambdaExpression, token),
	PostfixUnaryExpressionSyntax postfixUnary => InferTypeInPostfixUnaryExpression(postfixUnary, token),
	PrefixUnaryExpressionSyntax prefixUnary => InferTypeInPrefixUnaryExpression(prefixUnary, token),
	RelationalPatternSyntax relationalPattern => InferTypeInRelationalPattern(relationalPattern),
	ReturnStatementSyntax returnStatement => InferTypeForReturnStatement(returnStatement, token),
	SingleVariableDesignationSyntax singleVariableDesignationSyntax => InferTypeForSingleVariableDesignation(singleVariableDesignationSyntax),
	SwitchLabelSyntax switchLabel => InferTypeInSwitchLabel(switchLabel, token),
	SwitchStatementSyntax switchStatement => InferTypeInSwitchStatement(switchStatement, token),
	ThrowStatementSyntax throwStatement => InferTypeInThrowStatement(throwStatement, token),
	TupleExpressionSyntax tupleExpression => InferTypeInTupleExpression(tupleExpression, token),
	UnaryPatternSyntax unaryPattern => GetPatternTypes(unaryPattern),
	UsingStatementSyntax usingStatement => InferTypeInUsingStatement(usingStatement, token),
	WhenClauseSyntax whenClause => InferTypeInWhenClause(whenClause, token),
	WhileStatementSyntax whileStatement => InferTypeInWhileStatement(whileStatement, token),
	YieldStatementSyntax yieldStatement => InferTypeInYieldStatement(yieldStatement, token),
	_ => SpecializedCollections.EmptyEnumerable<TypeInferenceInfo>(),
	};

We should make sure there is a single method of the two that have this switch expression, and should make sure that cases from both are handled.

[vibeeshan025]

New to Roslyn's contribution. Shall I work on this?

[CyrusNajmabadi]

Sure. You could work on this!