Incorrect formatting behaviour when using SyntaxFactory.Block

[bjornhellander]

Version Used: 4.3.0-2.final (same behaviour with 4.3.0-3, but not with 4.3.0-1)

After updating the c# 11 test project in StyleCop.Analyzers to use a new Roslyn version, three tests (all called TestCodeFixProviderWithAlternateIndentationAsync) failed due to different formatting behaviour when adding braces around code in if statements (using SyntaxFactory.Block).

See DotNetAnalyzers/StyleCopAnalyzers#3535 for updated code.
The call to SyntaxFactory.Block is made here: https://github.com/bjornhellander/StyleCopAnalyzers/blob/feature/sa1206-required/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/LayoutRules/SA1503CodeFixProvider.cs#L72
And here we set indentation size to 1 in the failing test cases: https://github.com/bjornhellander/StyleCopAnalyzers/blob/feature/sa1206-required/StyleCop.Analyzers/StyleCop.Analyzers.Test/Verifiers/StyleCopCodeFixVerifier%602.cs#L120

The three tests fail in slightly different ways, but the fixed code seems to have indentation size 4, instead of the specified and expected 1:

using System.Diagnostics;

public class Foo
{
 public void Bar(int i)
 {
  if (i == 0)
-  {
-   Debug.Assert(true);
-  }
- }
+        {
+            Debug.Assert(true);
+        }
+    }
}

[bjornhellander]

Any chance on getting some attention to this?

Since the release of Visual Studio 17.4 (Roslyn 4.4.0) this now happens IRL (as in "not just in tests") when applying the code fix for SA1503 in StyleCop.Analyzers. See DotNetAnalyzers/StyleCopAnalyzers#3581.

[bjornhellander]

I added https://github.com/bjornhellander/BlockFormattingProblem as a simpler repro, in case it helps. It contains one test case which are run using two different versions of Roslyn. The test passes with the older version and fails with the newer.

[CyrusNajmabadi]

@tmat sounds like maybe the same issue as the option serialization bug?

[sharwell]

@tmat @jasonmalinowski This is blocking the use of the 4.4.0 Roslyn packages on NuGet. I believe this was serviced; we will need a new set of 4.4.1 packages uploaded to NuGet before the fix can be rolled out.