New rename dialog always renames file once checkbox is selected

[NTaylorMullen]

Version Used: VSMain

Steps to Reproduce:

Pre-req: Enable new rename dialog

1. Initiate the rename on a class
2. Select "Rename file":
   
3. Execute it
4. Go to another local somewhere and rename it

Expected Behavior: Local is renamed and file is not renamed to match

Actual Behavior: Local and file get renamed to be the same

/cc @ryzngard

[KirillOsenkov]

@ryzngard this bug is very impactful for VSMac, any rename operation renames the file. Would be nice to prioritize this.

I think we should flip the default of RenameFile option to false, for other Roslyn hosts as well.

[ryzngard]

@ryzngard this bug is very impactful for VSMac, any rename operation renames the file. Would be nice to prioritize this.

I think we should flip the default of RenameFile option to false, for other Roslyn hosts as well.

Is this only for the new rename dialog that's a preview feature? I didn't think that was applicable to VSMac... Likely a different issue entirely.

[KirillOsenkov]

we still use the old rename dialog in VSMac and it broke with the latest Roslyn insertion

[KirillOsenkov]

Confirmed setting InlineRenameSessionOptionsStorage.RenameFile to false fixes the bug for us.

[drewnoakes]

I just started seeing this today. I rename stuff all the time. Has something changed recently?

[davidwengier]

The issue, AFAIK, is the checkbox state being used in places it shouldn't. Perhaps you only recently checked the checkbox?