Rename options to editorconfig like name (#66899)

* Change block structure options to editorconfig-like name

* Move brace completion/classification/prefer hashcode/color scheme to new name

* Move completion options to new names

* Move provide date and time completion to new name

* Move diagnostic options to new names

* Move documentation and documentOutline to new name

* Move editor component options to new name

* Move extract method option to new name

* Move fading options to new name

* Move database storage to new name

* Move find usage options to new name

* Move formatting options to new name

* Move generate code option to new name

* Move implement type options to new name

* Move all the inline hints options to new name

* Move inline rename options to new name

* Move Json features option to new name

* Move key binding reset options to new name

* Move logger option and lsp options to new name

* Move quick info options to new name

* Move regular expression options to new name:

* Move solution crawler options to new name

* Move spilit comment/string options to new name

* Move stacktrace explorer to new name

* Move suggestion option async to new name

* Move symbol search option to new name

* Move task list options to new name

* Move format string option to new name

* Move workspace configuration to new name

* Move xaml options to new name

* Move internal diagnostics options to new name

* Move internal feature on off options to new name

* Move solution crawler options to new name

* Move service feature on off options to new name

* Fix the wrongly upcase OOP

* Change csharp_split_string_literal_options_enabled to csharp_split_string_literal_on_return

* Rename Inline hints view options

* Rename diagnostic tagging options

* Change FormattingOptonsMetadata

* Rename block structure options

* Rename format on close brace

* Rename classsify

* Rename prefer hashcode

* Rename color scheme

* Rename completion options

* Revisit block structure options

* Rename date and time completion, pull diagnostic, comment generation, document outline

* Rename format, constructor generation, hashcode and equals generation, implement type options

* Rename inline hints options

* Rename rename options

* Rename diagnostics options

* Rename InternalFeatureOnOff options'

* Rename Json options

* Rename keybidingResetOptions

* Rename logger options

* Rename lsp options

* Rename navigator bar and regex options

* Rename show signature, naming, solution crawler split comment, stacktrace explorer, suggestions, symbol search, and suugested types options

* Rename task list item, wrap line length, and report invalid string dot format calls options

* Rename workspace and xaml options

* rename hide in advanced members

* Rename semantic_colorizer and syntactic colorizer

* Fully qualified lsp

* Fully qualified lsp in xaml options

* Unify the enable word

* Unify the disable word

* Remove 'all' from display_inline_hints_while_pressing_alt_f1

* Rename dotnet_inline_hints_colorize to dotnet_colorize_inline_hints

* Rename dotnet_tagging_pull_diagnostic to dotnet_pull_diagnostic_tagging

* Change extracting to extract in dotnet_allow_best_effort_when_extracting_method

* Rename dotnet_select_all_when_generate_overrides

* Rename dotnet_generate_equals_and_get_hash_code_from_members_when_generate_operators

* Rename dotnet_generate_equals_and_get_hash_code_from_members_when_implement_iequatable

* Rename dotnet_add_null_checks_when_generate_constructor_from_members

* Remove the duplicate AddNullChecksToConstructorsGeneratedFromMembers

* Rename dotnet_enable_oop_64_bit

* Rename dotnet_enable_oop_server_gc

* Rename dotnet_enable_oop_core_clr

* Rename dotnet_split_comment

* Rename dotnet_completion_enter_key_behavior

* Rename dotnet_don't_put_out_or_ref_on_struct_when_extract_method

* Rename dotnet_insertion_behavior_when_implement_type

* Rename dotnet_property_generation_behavior_when_implement_type

* Rename dotnet_suggest_for_types_in_reference_assemblies

* Rename SymbolSearchOptions

* Rename intellicode options

* Rename FindUsagesOptions

* Rename xaml options

* Rename dotnet_visual_studio_workspace_partial_load_mode

* Rename dotnet_code_style_prefer_system_hash_code

* Rename dotnet_smart_indent

* Fix the missing xaml options

* Change to dotent for csharp_show_new_snippet_experience_feature_flag, csharp_show_new_snippet_experience, csharp_disable_unnamed_symbol_completion, csharp_normal_diagnostic_mode, csharp_event_hook_up, visual_basic_format_on_save, csharp_enable_snippets, csharp_open_stack_trace_explorer_on_focus, visual_basic_visual_studio_navigation_options_navigate_to_object_browser and csharp_lsp_pull_diagnostics

* Rename SplitStringLiteralOptions

* Rename InlineHintsViewOptions

* Rename DiagnosticsTaggingOptions

* Rename InlineDiagnosticsOptions

* Rename FormattingOptions

* Rename InlineRenameUIOptionsStorage

* Rename CompletionViewOptions

* Rename RemoteHostOptions

* Rename SplitCommentOptions

* Rename SuggestionsOptions

* Rename InternalDiagnosticsOptions

* Rename LspOptions

* Rename DocumentOutlineOptions

* Rename ColorSchemeOptions

* Rename KeybindingResetOptions

* Rename LoggerOptions

* Rename StackTraceExplorer options

* Rename SymbolSearchGlobalOptions

* Rename VisualStudioLoggingOptionsMetadata

* VisualStudioNavigationOptions

* Rename FadingOptions

* Revert "Rename FadingOptions"

This reverts commit 09fb3ce.

* Move BranceMatcingOptions to seperate file

* Move DiagnosticsClassificationOptions to seperate file

* Move SemanticsColorizer to seperate file

* Move AutomaticLineEnder and SyntacticColorizer options to seperate files

* Move smart indenter options to seperate file

* Move dotnet_squiggles to seperate file

* Move FormatOnSave to seperate file

* Move RenameTracking options to seperate file

* Move EventHookup to seperate file

* Move snippets options to seperate file

* Move VirtualMemoryNotificationListener options to seperate file and remove InternalFeatureOnOffOptions

* Fix the namespace of SmartIndent

* Correct the namespace

* Add enable in rename tracking

* Remove the features in implement type options

* Rename to lsp

* Rename dotnet_navigate_to_object_browser

* Rename dotnet_automatic_line_ender

* Add enable to brace matching

* Add enable to classification and squiggles

* Add enable to event hookup

* Add enable to smart indenter

* Add enable to async sugguestions

* Remove under_cursor suffix

* Add visual studio prefix to Color scheme

* Add visual_studio to keybinding reset options

* Add visual_studio prefix in logger options storage

* Add visual_studio prefix to SymbolSearchGlobalOptionStorage

* Add visual_studio prefix to VisualStudioLoggingOptionsStorage

* Add visual_studio prefix to navigate to object browser

* Remove dotnet in color scheme

* Replace visual_studio_dotnet to visual_studio

Author: Cosifne

src/EditorFeatures/CSharp/EventHookup/EventHookupCommandHandler_TabKeyCommand.cs

@@ -17,6 +17,7 @@
 using Microsoft.CodeAnalysis.Editing;
 using Microsoft.CodeAnalysis.Editor.Shared.Extensions;
 using Microsoft.CodeAnalysis.Editor.Shared.Options;
+using Microsoft.CodeAnalysis.EventHookup;
 using Microsoft.CodeAnalysis.Formatting;
 using Microsoft.CodeAnalysis.Internal.Log;
 using Microsoft.CodeAnalysis.LanguageService;
@@ -39,7 +40,7 @@ internal partial class EventHookupCommandHandler : IChainedCommandHandler<TabKey
         public void ExecuteCommand(TabKeyCommandArgs args, Action nextHandler, CommandExecutionContext context)
         {
             _threadingContext.ThrowIfNotOnUIThread();
-            if (!_globalOptions.GetOption(InternalFeatureOnOffOptions.EventHookup))
+            if (!_globalOptions.GetOption(EventHookupOptionsStorage.EventHookup))
             {
                 nextHandler();
                 return;

src/EditorFeatures/CSharp/EventHookup/EventHookupCommandHandler_TypeCharCommand.cs

@@ -7,13 +7,12 @@
 using System;
 using System.Threading;
 using Microsoft.CodeAnalysis.Editor.Shared.Extensions;
-using Microsoft.CodeAnalysis.Editor.Shared.Options;
+using Microsoft.CodeAnalysis.EventHookup;
 using Microsoft.CodeAnalysis.Internal.Log;
 using Microsoft.VisualStudio.Commanding;
 using Microsoft.VisualStudio.Text;
 using Microsoft.VisualStudio.Text.Editor;
 using Microsoft.VisualStudio.Text.Editor.Commanding.Commands;
-using Roslyn.Utilities;
 
 namespace Microsoft.CodeAnalysis.Editor.CSharp.EventHookup
 {
@@ -24,7 +23,7 @@ public void ExecuteCommand(TypeCharCommandArgs args, Action nextHandler, Command
             _threadingContext.ThrowIfNotOnUIThread();
             nextHandler();
 
-            if (!_globalOptions.GetOption(InternalFeatureOnOffOptions.EventHookup))
+            if (!_globalOptions.GetOption(EventHookupOptionsStorage.EventHookup))
             {
                 EventHookupSessionManager.CancelAndDismissExistingSessions();
                 return;

src/EditorFeatures/CSharp/SplitStringLiteral/SplitStringLiteralCommandHandler.cs

@@ -54,8 +54,10 @@ public bool ExecuteCommand(ReturnKeyCommandArgs args, CommandExecutionContext co
 
         public bool ExecuteCommandWorker(ReturnKeyCommandArgs args, CancellationToken cancellationToken)
         {
-            if (!_editorOptionsService.GlobalOptions.GetOption(SplitStringLiteralOptions.Enabled))
+            if (!_editorOptionsService.GlobalOptions.GetOption(SplitStringLiteralOptionsStorage.Enabled))
+            {
                 return false;
+            }
 
             var textView = args.TextView;
             var subjectBuffer = args.SubjectBuffer;

src/EditorFeatures/CSharp/SplitStringLiteral/SplitStringLiteralOptions.cs renamed to src/EditorFeatures/CSharp/SplitStringLiteral/SplitStringLiteralOptionsStorage.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.CodeAnalysis.Editor.CSharp.SplitStringLiteral;
 
-internal sealed class SplitStringLiteralOptions
+internal sealed class SplitStringLiteralOptionsStorage
 {
-    public static Option2<bool> Enabled = new("SplitStringLiteralOptions_Enabled", defaultValue: true);
+    public static Option2<bool> Enabled = new("csharp_split_string_literal_on_return", defaultValue: true);
 }

src/EditorFeatures/CSharpTest/InlineDiagnostics/InlineDiagnosticsTaggerProviderTests.cs

@@ -57,7 +57,7 @@ private static async Task<ImmutableArray<ITagSpan<InlineDiagnosticsTag>>> GetTag
 
         private static async Task<ImmutableArray<ITagSpan<InlineDiagnosticsTag>>> GetTagSpansAsync(TestWorkspace workspace)
         {
-            workspace.GlobalOptions.SetGlobalOption(InlineDiagnosticsOptions.EnableInlineDiagnostics, LanguageNames.CSharp, true);
+            workspace.GlobalOptions.SetGlobalOption(InlineDiagnosticsOptionsStorage.EnableInlineDiagnostics, LanguageNames.CSharp, true);
             return (await TestDiagnosticTagProducer<InlineDiagnosticsTaggerProvider, InlineDiagnosticsTag>.GetDiagnosticsAndErrorSpans(workspace)).Item2;
         }
     }

src/EditorFeatures/CSharpTest/Squiggles/ErrorSquiggleProducerTests.cs

@@ -81,7 +81,7 @@ void Test()
 </Workspace>";
 
             using var workspace = TestWorkspace.Create(workspaceXml);
-            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptions.PullDiagnosticTagging, pull);
+            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptionsStorage.PullDiagnosticTagging, pull);
 
             var spans = (await TestDiagnosticTagProducer<DiagnosticsSquiggleTaggerProvider, IErrorTag>.GetDiagnosticsAndErrorSpans(workspace)).Item2;
 
@@ -117,7 +117,7 @@ void Test()
             using var workspace = TestWorkspace.Create(workspaceXml, composition: SquiggleUtilities.CompositionWithSolutionCrawler);
             var language = workspace.Projects.Single().Language;
 
-            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptions.PullDiagnosticTagging, pull);
+            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptionsStorage.PullDiagnosticTagging, pull);
 
             workspace.GlobalOptions.SetGlobalOption(
                 CodeStyleOptions2.PreferIntrinsicPredefinedTypeKeywordInDeclaration, language,
@@ -212,7 +212,7 @@ public async Task SemanticErrorReported(bool pull)
         {
             using var workspace = TestWorkspace.CreateCSharp("class C : Bar { }", composition: SquiggleUtilities.CompositionWithSolutionCrawler);
 
-            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptions.PullDiagnosticTagging, pull);
+            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptionsStorage.PullDiagnosticTagging, pull);
 
             var spans = await TestDiagnosticTagProducer<DiagnosticsSquiggleTaggerProvider, IErrorTag>.GetDiagnosticsAndErrorSpans(workspace);
 
@@ -237,7 +237,7 @@ public async Task SemanticErrorReported(bool pull)
         public async Task TestNoErrorsAfterDocumentRemoved(bool pull)
         {
             using var workspace = TestWorkspace.CreateCSharp("class");
-            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptions.PullDiagnosticTagging, pull);
+            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptionsStorage.PullDiagnosticTagging, pull);
 
             using var wrapper = new DiagnosticTaggerWrapper<DiagnosticsSquiggleTaggerProvider, IErrorTag>(workspace);
 
@@ -267,7 +267,7 @@ public async Task TestNoErrorsAfterDocumentRemoved(bool pull)
         public async Task TestNoErrorsAfterProjectRemoved(bool pull)
         {
             using var workspace = TestWorkspace.CreateCSharp("class");
-            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptions.PullDiagnosticTagging, pull);
+            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptionsStorage.PullDiagnosticTagging, pull);
 
             using var wrapper = new DiagnosticTaggerWrapper<DiagnosticsSquiggleTaggerProvider, IErrorTag>(workspace);
 
@@ -313,7 +313,7 @@ class Test
 </Workspace>";
 
             using var workspace = TestWorkspace.Create(workspaceXml, composition: s_mockComposition);
-            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptions.PullDiagnosticTagging, pull);
+            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptionsStorage.PullDiagnosticTagging, pull);
 
             var document = workspace.Documents.First();
 
@@ -357,7 +357,7 @@ class Test
 </Workspace>";
 
             using var workspace = TestWorkspace.Create(workspaceXml, composition: s_mockComposition);
-            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptions.PullDiagnosticTagging, pull);
+            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptionsStorage.PullDiagnosticTagging, pull);
 
             var document = workspace.Documents.First();
 
@@ -401,7 +401,7 @@ private static async Task<ImmutableArray<ITagSpan<IErrorTag>>> GetTagSpansInSour
 
         private static async Task<ImmutableArray<ITagSpan<IErrorTag>>> GetTagSpansAsync(TestWorkspace workspace, bool pull)
         {
-            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptions.PullDiagnosticTagging, pull);
+            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptionsStorage.PullDiagnosticTagging, pull);
 
             return (await TestDiagnosticTagProducer<DiagnosticsSquiggleTaggerProvider, IErrorTag>.GetDiagnosticsAndErrorSpans(workspace)).Item2;
         }

src/EditorFeatures/CSharpTest/SuggestionTags/SuggestionTagProducerTests.cs

@@ -44,7 +44,7 @@ void M() {
             string content, bool pull)
         {
             using var workspace = TestWorkspace.CreateCSharp(content);
-            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptions.PullDiagnosticTagging, pull);
+            workspace.GlobalOptions.SetGlobalOption(DiagnosticTaggingOptionsStorage.PullDiagnosticTagging, pull);
 
             var analyzerMap = new Dictionary<string, ImmutableArray<DiagnosticAnalyzer>>()
             {

src/EditorFeatures/Core.Cocoa/Options/VisualStudioMacOptionsStorage.cs

@@ -56,22 +56,22 @@ public string GetName(string? language)
     /// </summary>
     public static readonly IReadOnlyDictionary<string, PropertyName> PersistedOptionsWithLegacyPropertyNames = new Dictionary<string, PropertyName>()
     {
-        {"BraceCompletionOptions_AutoFormattingOnCloseBrace", new PropertyName("TextEditor.%LANGUAGE%.Specific.Auto Formatting On Close Brace")},
-        {"FormattingOptions_AutoFormattingOnReturn", new PropertyName("TextEditor.%LANGUAGE%.Specific.Auto Formatting On Return")},
-        {"FormattingOptions_AutoFormattingOnSemicolon", new PropertyName("TextEditor.%LANGUAGE%.Specific.Auto Formatting On Semicolon")},
-        {"FormattingOptions_AutoFormattingOnTyping", new PropertyName("TextEditor.%LANGUAGE%.Specific.Auto Formatting On Typing")},
-        {"FormattingOptions_FormatOnPaste", new PropertyName("TextEditor.%LANGUAGE%.SpeciAddImportsOnPaste2fic.FormatOnPaste")},
+        {"csharp_format_on_close_brace", new PropertyName("TextEditor.%LANGUAGE%.Specific.Auto Formatting On Close Brace")},
+        {"csharp_format_on_return", new PropertyName("TextEditor.%LANGUAGE%.Specific.Auto Formatting On Return")},
+        {"csharp_format_on_semicolon", new PropertyName("TextEditor.%LANGUAGE%.Specific.Auto Formatting On Semicolon")},
+        {"csharp_format_on_typing", new PropertyName("TextEditor.%LANGUAGE%.Specific.Auto Formatting On Typing")},
+        {"dotnet_format_on_paste", new PropertyName("TextEditor.%LANGUAGE%.SpeciAddImportsOnPaste2fic.FormatOnPaste")},
         {"dotnet_sort_system_directives_first", new PropertyName("TextEditor.%LANGUAGE%.Specific.PlaceSystemNamespaceFirst")},
         {"dotnet_separate_import_directive_groups", new PropertyName("TextEditor.%LANGUAGE%.Specific.SeparateImportDirectiveGroups")},
-        {"QuickInfoOptions_ShowRemarksInQuickInfo", new PropertyName("TextEditor.%LANGUAGE%.Specific.ShowRemarks")},
+        {"dotnet_show_remarks_in_quick_info", new PropertyName("TextEditor.%LANGUAGE%.Specific.ShowRemarks")},
         {"dotnet_add_imports_on_paste", new PropertyName("TextEditor.%LANGUAGE%.Specific.AddImportsOnPaste2")},
-        {"CompletionOptions_ShowItemsFromUnimportedNamespaces", new PropertyName("TextEditor.%LANGUAGE%.Specific.ShowItemsFromUnimportedNamespaces")},
-        {"CompletionOptions_TriggerOnDeletion", new PropertyName("TextEditor.%LANGUAGE%.Specific.TriggerOnDeletion")},
-        {"CompletionOptions_TriggerOnTypingLetters", new PropertyName("TextEditor.%LANGUAGE%.Specific.TriggerOnTypingLetters")},
-        {"CompletionOptions_ShowCompletionItemFilters", new PropertyName("TextEditor.%LANGUAGE%.Specific.ShowCompletionItemFilters")},
-        {"SolutionCrawlerOptionsStorage_BackgroundAnalysisScopeOption", new PropertyName("TextEditor.%LANGUAGE%.Specific.BackgroundAnalysisScopeOption")},
-        {"SolutionCrawlerOptionsStorage_CompilerDiagnosticsScopeOption", new PropertyName("TextEditor.%LANGUAGE%.Specific.CompilerDiagnosticsScopeOption")},
-        {"SymbolSearchOptions_SuggestForTypesInNuGetPackages", new PropertyName("TextEditor.%LANGUAGE%.Specific.SuggestForTypesInNuGetPackages")},
+        {"dotnet_show_completion_items_from_unimported_namespaces", new PropertyName("TextEditor.%LANGUAGE%.Specific.ShowItemsFromUnimportedNamespaces")},
+        {"dotnet_trigger_completion_on_deletion", new PropertyName("TextEditor.%LANGUAGE%.Specific.TriggerOnDeletion")},
+        {"dotnet_trigger_completion_on_typing_letters", new PropertyName("TextEditor.%LANGUAGE%.Specific.TriggerOnTypingLetters")},
+        {"dotnet_show_completion_item_filters", new PropertyName("TextEditor.%LANGUAGE%.Specific.ShowCompletionItemFilters")},
+        {"dotnet_solution_crawler_background_analysis_scope", new PropertyName("TextEditor.%LANGUAGE%.Specific.BackgroundAnalysisScopeOption")},
+        {"dotnet_compiler_diagnostics_scope", new PropertyName("TextEditor.%LANGUAGE%.Specific.CompilerDiagnosticsScopeOption")},
+        {"dotnet_search_nuget_packages", new PropertyName("TextEditor.%LANGUAGE%.Specific.SuggestForTypesInNuGetPackages")},
         {"csharp_complete_statement_on_semicolon", new PropertyName("TextEditor.AutomaticallyCompleteStatementOnSemicolon")},
     };
 }

src/EditorFeatures/Core.Cocoa/Snippets/AbstractSnippetCommandHandler.cs

@@ -10,6 +10,7 @@
 using Microsoft.CodeAnalysis.LanguageService;
 using Microsoft.CodeAnalysis.Options;
 using Microsoft.CodeAnalysis.Shared.Extensions;
+using Microsoft.CodeAnalysis.Snippets;
 using Microsoft.CodeAnalysis.Text;
 using Microsoft.VisualStudio.Commanding;
 using Microsoft.VisualStudio.Text;
@@ -290,7 +291,7 @@ protected bool TryHandleTypedSnippet(ITextView textView, ITextBuffer subjectBuff
 
         protected bool AreSnippetsEnabled(EditorCommandArgs args)
         {
-            return EditorOptionsService.GlobalOptions.GetOption(InternalFeatureOnOffOptions.Snippets) &&
+            return EditorOptionsService.GlobalOptions.GetOption(SnippetsOptionsStorage.Snippets) &&
                 // TODO (https://github.com/dotnet/roslyn/issues/5107): enable in interactive
                 !(Workspace.TryGetWorkspace(args.SubjectBuffer.AsTextContainer(), out var workspace) && workspace.Kind == WorkspaceKind.Interactive);
         }

src/EditorFeatures/Core.Wpf/InlineDiagnostics/InlineDiagnosticsAdornmentManager.cs

@@ -69,7 +69,7 @@ private void TextView_ViewportWidthChanged(object sender, EventArgs e)
                 return;
             }
 
-            var option = _globalOptions.GetOption(InlineDiagnosticsOptions.Location, document.Project.Language);
+            var option = _globalOptions.GetOption(InlineDiagnosticsOptionsStorage.Location, document.Project.Language);
             if (option == InlineDiagnosticsLocations.PlacedAtEndOfEditor)
             {
                 var normalizedCollectionSpan = new NormalizedSnapshotSpanCollection(TextView.TextViewLines.FormattedSpan);