Skip to content

Commit 09fb3ce

Browse files
committed
Rename FadingOptions
1 parent 1f04902 commit 09fb3ce

File tree

9 files changed

+18
-18
lines changed

9 files changed

+18
-18
lines changed

src/Analyzers/CSharp/Analyzers/RemoveUnreachableCode/CSharpRemoveUnreachableCodeDiagnosticAnalyzer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public CSharpRemoveUnreachableCodeDiagnosticAnalyzer()
2525
: base(IDEDiagnosticIds.RemoveUnreachableCodeDiagnosticId,
2626
EnforceOnBuildValues.RemoveUnreachableCode,
2727
option: null,
28-
fadingOption: FadingOptions.FadeOutUnreachableCode,
28+
fadingOption: FadingOptionsStorage.FadeOutUnreachableCode,
2929
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Unreachable_code_detected), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
3030
configurable: false)
3131
{

src/Analyzers/Core/Analyzers/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ internal abstract class AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer<TSynt
2929
private readonly DiagnosticDescriptor _generatedCodeClassificationIdDescriptor;
3030

3131
protected AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer(LocalizableString titleAndMessage)
32-
: base(GetDescriptors(titleAndMessage, out var classificationIdDescriptor, out var generatedCodeClassificationIdDescriptor), FadingOptions.FadeOutUnusedImports)
32+
: base(GetDescriptors(titleAndMessage, out var classificationIdDescriptor, out var generatedCodeClassificationIdDescriptor), FadingOptionsStorage.FadeOutUnusedImports)
3333
{
3434
_classificationIdDescriptor = classificationIdDescriptor;
3535
_generatedCodeClassificationIdDescriptor = generatedCodeClassificationIdDescriptor;

src/EditorFeatures/Test/Diagnostics/DiagnosticsClassificationTaggerProviderTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ public async Task Test_FadingOptions(string diagnosticId, bool fadingOptionValue
169169
private static PerLanguageOption2<bool> GetFadingOptionForDiagnostic(string diagnosticId)
170170
=> diagnosticId switch
171171
{
172-
IDEDiagnosticIds.RemoveUnnecessaryImportsDiagnosticId => FadingOptions.FadeOutUnusedImports,
173-
IDEDiagnosticIds.RemoveUnreachableCodeDiagnosticId => FadingOptions.FadeOutUnreachableCode,
172+
IDEDiagnosticIds.RemoveUnnecessaryImportsDiagnosticId => FadingOptionsStorage.FadeOutUnusedImports,
173+
IDEDiagnosticIds.RemoveUnreachableCodeDiagnosticId => FadingOptionsStorage.FadeOutUnreachableCode,
174174
_ => throw ExceptionUtilities.UnexpectedValue(diagnosticId),
175175
};
176176
}

src/Features/LanguageServer/ProtocolUnitTests/Diagnostics/PullDiagnosticTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -700,7 +700,7 @@ class A
700700
}";
701701
await using var testLspServer = await CreateTestWorkspaceWithDiagnosticsAsync(markup, BackgroundAnalysisScope.OpenFiles, useVSDiagnostics);
702702
var firstLocation = testLspServer.GetLocations("first").Single().Range;
703-
testLspServer.TestWorkspace.GlobalOptions.SetGlobalOption(FadingOptions.FadeOutUnusedImports, LanguageNames.CSharp, true);
703+
testLspServer.TestWorkspace.GlobalOptions.SetGlobalOption(FadingOptionsStorage.FadeOutUnusedImports, LanguageNames.CSharp, true);
704704

705705
var document = testLspServer.GetCurrentSolution().Projects.Single().Documents.Single();
706706

@@ -739,7 +739,7 @@ class A
739739
}";
740740
await using var testLspServer = await CreateTestWorkspaceWithDiagnosticsAsync(markup, BackgroundAnalysisScope.OpenFiles, useVSDiagnostics);
741741
var firstLocation = testLspServer.GetLocations("first").Single().Range;
742-
testLspServer.TestWorkspace.GlobalOptions.SetGlobalOption(FadingOptions.FadeOutUnusedImports, LanguageNames.CSharp, false);
742+
testLspServer.TestWorkspace.GlobalOptions.SetGlobalOption(FadingOptionsStorage.FadeOutUnusedImports, LanguageNames.CSharp, false);
743743

744744
var document = testLspServer.GetCurrentSolution().Projects.Single().Documents.Single();
745745

src/VisualStudio/CSharp/Impl/Options/AdvancedOptionPageControl.xaml.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,8 @@ public AdvancedOptionPageControl(OptionStore optionStore, IComponentModel compon
115115
BindToOption(Collapse_regions_when_collapsing_to_definitions, BlockStructureOptionsStorage.CollapseRegionsWhenCollapsingToDefinitions, LanguageNames.CSharp);
116116

117117
// Fading
118-
BindToOption(Fade_out_unused_usings, FadingOptions.FadeOutUnusedImports, LanguageNames.CSharp);
119-
BindToOption(Fade_out_unreachable_code, FadingOptions.FadeOutUnreachableCode, LanguageNames.CSharp);
118+
BindToOption(Fade_out_unused_usings, FadingOptionsStorage.FadeOutUnusedImports, LanguageNames.CSharp);
119+
BindToOption(Fade_out_unreachable_code, FadingOptionsStorage.FadeOutUnreachableCode, LanguageNames.CSharp);
120120

121121
// Block Structure Guides
122122
BindToOption(Show_guides_for_declaration_level_constructs, BlockStructureOptionsStorage.ShowBlockStructureGuidesForDeclarationLevelConstructs, LanguageNames.CSharp);

src/VisualStudio/CSharp/Impl/Options/AutomationObject/AutomationObject.Fading.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ public partial class AutomationObject
1010
{
1111
public int Fading_FadeOutUnreachableCode
1212
{
13-
get { return GetBooleanOption(FadingOptions.FadeOutUnreachableCode); }
14-
set { SetBooleanOption(FadingOptions.FadeOutUnreachableCode, value); }
13+
get { return GetBooleanOption(FadingOptionsStorage.FadeOutUnreachableCode); }
14+
set { SetBooleanOption(FadingOptionsStorage.FadeOutUnreachableCode, value); }
1515
}
1616

1717
public int Fading_FadeOutUnusedImports
1818
{
19-
get { return GetBooleanOption(FadingOptions.FadeOutUnusedImports); }
20-
set { SetBooleanOption(FadingOptions.FadeOutUnusedImports, value); }
19+
get { return GetBooleanOption(FadingOptionsStorage.FadeOutUnusedImports); }
20+
set { SetBooleanOption(FadingOptionsStorage.FadeOutUnusedImports, value); }
2121
}
2222
}
2323
}

src/VisualStudio/VisualBasic/Impl/Options/AdvancedOptionPageControl.xaml.vb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.VisualBasic.Options
107107
BindToOption(Collapse_regions_when_collapsing_to_definitions, BlockStructureOptionsStorage.CollapseRegionsWhenCollapsingToDefinitions, LanguageNames.VisualBasic)
108108

109109
' Fading
110-
BindToOption(Fade_out_unused_imports, FadingOptions.FadeOutUnusedImports, LanguageNames.VisualBasic)
110+
BindToOption(Fade_out_unused_imports, FadingOptionsStorage.FadeOutUnusedImports, LanguageNames.VisualBasic)
111111

112112
' Block structure guides
113113
BindToOption(Show_guides_for_declaration_level_constructs, BlockStructureOptionsStorage.ShowBlockStructureGuidesForDeclarationLevelConstructs, LanguageNames.VisualBasic)

src/VisualStudio/VisualBasic/Impl/Options/AutomationObject/AutomationObject.Fading.vb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,19 @@ Namespace Microsoft.VisualStudio.LanguageServices.VisualBasic.Options
88
Partial Public Class AutomationObject
99
Public Property Fading_FadeOutUnreachableCode As Boolean
1010
Get
11-
Return GetBooleanOption(FadingOptions.FadeOutUnreachableCode)
11+
Return GetBooleanOption(FadingOptionsStorage.FadeOutUnreachableCode)
1212
End Get
1313
Set(value As Boolean)
14-
SetBooleanOption(FadingOptions.FadeOutUnreachableCode, value)
14+
SetBooleanOption(FadingOptionsStorage.FadeOutUnreachableCode, value)
1515
End Set
1616
End Property
1717

1818
Public Property Fading_FadeOutUnusedImports As Boolean
1919
Get
20-
Return GetBooleanOption(FadingOptions.FadeOutUnusedImports)
20+
Return GetBooleanOption(FadingOptionsStorage.FadeOutUnusedImports)
2121
End Get
2222
Set(value As Boolean)
23-
SetBooleanOption(FadingOptions.FadeOutUnusedImports, value)
23+
SetBooleanOption(FadingOptionsStorage.FadeOutUnusedImports, value)
2424
End Set
2525
End Property
2626
End Class

src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/CodeStyle/FadingOptions.cs renamed to src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/CodeStyle/FadingOptionsStorage.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
namespace Microsoft.CodeAnalysis.CodeStyle
99
{
10-
internal static class FadingOptions
10+
internal static class FadingOptionsStorage
1111
{
1212
public static readonly PerLanguageOption2<bool> FadeOutUnusedImports = new("dotnet_fade_out_unused_imports", defaultValue: true);
1313
public static readonly PerLanguageOption2<bool> FadeOutUnreachableCode = new("dotnet_fade_out_unreachable_code", defaultValue: true);

0 commit comments

Comments
 (0)