-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added ConfigFile to simplify AnalyzerConfigFile creation. #981
base: main
Are you sure you want to change the base?
Conversation
I'm a bit hesitant to add this here in the current form. Note that you can achieve the same outcome by defining the Here are issues I'd like to see addressed in a general API:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See notes in review
Thank you. Tried to take into account your comments. var actual = new EditorConfigFile
{
["root"] = "true",
["*", "key"] = "{|Literal:value|}",
}.ToString(); |
I did notice this. I believe you could resolve this by making var actual = new EditorConfigFile(root: true)
{
["*"] =
{
"key = {|Literal:value|}",
},
}.ToString(); or: var actual = new EditorConfigFile(root: true)
{
["*"] =
{
{ "key", "{|Literal:value|}" },
},
}.ToString(); |
Perhaps I do not understand something, but how to specify global values other than root, which can be anything? Will the values for the |
I recently got acquainted with your package and for me creating a configuration file was problematic until I found an example. I think this can simplify the entry threshold because it adds a specific Add method that will be used intuitively.