[Bug fixed] Fixed bug with implicit JObject convertion in source generator mustache sample. #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the first sample case of mustache section template in `UseMustacheGenerator.cs`, It would get result: "Hello Chris, You have just won 10000 dollars!". But it should be "Hello Chris, You have just won 10000 dollars! Well, 10000 dollars, after taxes." The problem here is the implicit json deserialization, so just add `Dictionary<string, object>` as explict type to get pass.
robersonliou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first sample case of mustache section template in
UseMustacheGenerator.cs, It would get result: "Hello Chris, You have just won 10000 dollars!".But it should be "Hello Chris, You have just won 10000 dollars! Well, 10000 dollars, after taxes."
The problem here is the implicit json deserialization, so just add
Dictionary<string, object>as explict type to get pass.