Remove framework specific packages#1144
Merged
sharwell merged 4 commits intodotnet:mainfrom Aug 12, 2024
Merged
Conversation
chsienki
approved these changes
Feb 1, 2024
Comment on lines
+49
to
+57
| * Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.XUnit | ||
| * Microsoft.CodeAnalysis.CSharp.CodeFix.Testing.XUnit | ||
| * Microsoft.CodeAnalysis.CSharp.CodeRefactoring.Testing.XUnit | ||
| * Microsoft.CodeAnalysis.CSharp.SourceGenerators.Testing.XUnit | ||
| * Microsoft.CodeAnalysis.CSharp.Analyzer.Testing | ||
| * Microsoft.CodeAnalysis.CSharp.CodeFix.Testing | ||
| * Microsoft.CodeAnalysis.CSharp.CodeRefactoring.Testing | ||
| * Microsoft.CodeAnalysis.CSharp.SourceGenerators.Testing | ||
| * Visual Basic | ||
| * Microsoft.CodeAnalysis.VisualBasic.Analyzer.Testing.XUnit | ||
| * Microsoft.CodeAnalysis.VisualBasic.CodeFix.Testing.XUnit | ||
| * Microsoft.CodeAnalysis.VisualBasic.CodeRefactoring.Testing.XUnit | ||
| * Microsoft.CodeAnalysis.VisualBasic.SourceGenerators.Testing.XUnit | ||
| * Microsoft.CodeAnalysis.VisualBasic.Analyzer.Testing | ||
| * Microsoft.CodeAnalysis.VisualBasic.CodeFix.Testing | ||
| * Microsoft.CodeAnalysis.VisualBasic.CodeRefactoring.Testing | ||
| * Microsoft.CodeAnalysis.VisualBasic.SourceGenerators.Testing |
Member
There was a problem hiding this comment.
This very much worries me here that we're making a source breaking change more or less for folks who consumed this. It seems a much smaller change would just be to remove the verifier implementation that is causing trouble here, and leave the packages and core scaffolding in place. This way:
- People who have to migrate their packages forward won't have to change a bunch of package references/usings.
- If we still have xunit specific value we do want to provide (say, xunit does offer a way to have richer exceptions), we have a natural process for restoring that without asking everybody to change their package references/usings again.
Contributor
Author
There was a problem hiding this comment.
We published a public 1.2 release with these types marked obsolete, finally giving us a path forward to remove them. 🎉
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
I updated this pull request to remove all framework specific packages. |
sharwell
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1099 (comment)
See #1127 (comment)
Closes #1099