Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable pragma SYSLIB0014 from CSharp CodeFix Verifiers #7387

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Aug 21, 2024

Workaround to address the failure in the official builds:

/mnt/vss/_work/1/s/src/Test.Utilities/CSharpSecurityCodeFixVerifier`2+Test.cs(24,21): error SYSLIB0014: 'ServicePointManager' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead. Settings on ServicePointManager no longer affect SslStream or HttpClient.' (https://aka.ms/dotnet-warnings/SYSLIB0014) [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Test.Utilities/CSharpSecurityCodeFixVerifier`2+Test.cs(29,21): error SYSLIB0014: 'ServicePointManager' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead. Settings on ServicePointManager no longer affect SslStream or HttpClient.' (https://aka.ms/dotnet-warnings/SYSLIB0014) [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Test.Utilities/CSharpCodeFixVerifier`2+Test.cs(27,21): error SYSLIB0014: 'ServicePointManager' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead. Settings on ServicePointManager no longer affect SslStream or HttpClient.' (https://aka.ms/dotnet-warnings/SYSLIB0014) [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Test.Utilities/CSharpCodeFixVerifier`2+Test.cs(32,21): error SYSLIB0014: 'ServicePointManager' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead. Settings on ServicePointManager no longer affect SslStream or HttpClient.' (https://aka.ms/dotnet-warnings/SYSLIB0014) [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
...
D:\a\_work\1\s\src\NetAnalyzers\UnitTests\Microsoft.NetCore.Analyzers\Security\DataSetDataTableInWebSerializableObjectGraphTests.cs(93,13): error SYSLIB0014: 'ServicePointManager' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead. Settings on ServicePointManager no longer affect SslStream or HttpClient.' (https://aka.ms/dotnet-warnings/SYSLIB0014)  [D:\a\_work\1\s\src\NetAnalyzers\UnitTests\Microsoft.CodeAnalysis.NetAnalyzers.UnitTests.csproj]
D:\a\_work\1\s\src\NetAnalyzers\UnitTests\Microsoft.NetCore.Analyzers\Security\DataSetDataTableInWebSerializableObjectGraphTests.cs(113,13): error SYSLIB0014: 'ServicePointManager' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead. Settings on ServicePointManager no longer affect SslStream or HttpClient.' (https://aka.ms/dotnet-warnings/SYSLIB0014) [D:\a\_work\1\s\src\NetAnalyzers\UnitTests\Microsoft.CodeAnalysis.NetAnalyzers.UnitTests.csproj]

The ideal fix would be to replace the functionality with the preferred new set of APIs.

This will be cherry-picked into the arcade deps flow for release/9.0.1xx:
#7386

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (94955fd) to head (6bc04de).
Report is 243 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7387      +/-   ##
==========================================
+ Coverage   96.43%   96.49%   +0.06%     
==========================================
  Files        1412     1443      +31     
  Lines      336968   345885    +8917     
  Branches    11143    11374     +231     
==========================================
+ Hits       324946   333754    +8808     
- Misses       9218     9248      +30     
- Partials     2804     2883      +79     

@carlossanlop carlossanlop enabled auto-merge (squash) August 21, 2024 21:52
@carlossanlop carlossanlop merged commit 052da18 into dotnet:main Aug 21, 2024
11 checks passed
@carlossanlop carlossanlop deleted the TempDisable branch August 21, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants