- 
                Notifications
    You must be signed in to change notification settings 
- Fork 480
Fix false-flag of CompareExchange and re-usage with loops #6979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
        
          
                ...s/Core/Microsoft.NetCore.Analyzers/Performance/AvoidSingleUseOfLocalJsonSerializerOptions.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...s/Core/Microsoft.NetCore.Analyzers/Performance/AvoidSingleUseOfLocalJsonSerializerOptions.cs
          
            Show resolved
            Hide resolved
        
      | Codecov Report
 @@           Coverage Diff            @@
##             main    #6979    +/-   ##
========================================
  Coverage   96.42%   96.43%            
========================================
  Files        1410     1410            
  Lines      335956   336154   +198     
  Branches    11095    11103     +8     
========================================
+ Hits       323956   324161   +205     
+ Misses       9207     9198     -9     
- Partials     2793     2795     +2      | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jozkee!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @buyaa-n is there any action required to get this fix bundled with .NET 8? | 
| I think it's same as runtime porting, let managers know and agreed with porting, create a backport with  | 
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
| /backport to release/8.0.1xx | 
| Started backporting to release/8.0.1xx: https://github.com/dotnet/roslyn-analyzers/actions/runs/6536547982 | 
Fixes #6957