[release/8.0.1xx] Runtime90357 6012 #6894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
approved these changes
Aug 25, 2023
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
Approving. I am going to assume we will need M2 approval as with any other 8.0 backports if this is merged before the snap.
@jeffhandley does this PR have your approval?
@buyaa-n once merged (if approved) we also need to confirm the change flows into the 8.0 branches of the subscribed repos: sdk, runtime and dotnet-monitor.
carlossanlop
added
the
servicing-consider
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/8.0.1xx #6894 +/- ##
================================================
Coverage 96.39% 96.39%
================================================
Files 1403 1403
Lines 330977 331069 +92
Branches 10890 10894 +4
================================================
+ Hits 319057 319146 +89
- Misses 9187 9190 +3
Partials 2733 2733 |
jeffhandley
approved these changes
Aug 25, 2023
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
Yes, this has my approval. Thanks, @carlossanlop, @buyaa-n, and @manfred-brands!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6885 to release/8.0.1xx
/cc @buyaa-n @manfred-brands
Customer Impact
Because of the bug
CA2241: Provide correct arguments to formatting methodsanalyzer throws IndexOutOfRangeException at runtime which causing a build failure in runtime repo and possibly cause same issue for repos that warns as error forAD0001Testing
Unit testing added with the fix, manual testing done with runtime repo
Risk
Low: The fix would cause new warning for an edge case scenario but as the analyzer is at
infolevel by default that is acceptable