Non-copyable analysis for fields and auto-properties #4798
Conversation
sharwell
commented
Feb 7, 2021
sharwell
commented
- Do not allow a non-copyable field to be defined in a copyable type
- Do not allow a non-copyable auto-property to be defined (the getter in this case always copies the backing field value)
| public override void VisitAlias(IAliasSymbol symbol) | ||
| { | ||
| base.VisitAlias(symbol); | ||
| } |
There was a problem hiding this comment.
i don't quite get the purpose of the overrides. is it just to be explicit that this is the behavior you want? (if so, that's fine. just trying to understand).
There was a problem hiding this comment.
Yes, this analyzer overrides everything.
|
|
||
| public override void VisitProperty(IPropertySymbol symbol) | ||
| { | ||
| // Auto-properties cannot have non-copyable types |
There was a problem hiding this comment.
probably worth commenting why?
There was a problem hiding this comment.
The user-facing description of the rule includes the explanation. The getter for an auto-property always copies the backing field, which is not allowed for a non-copyable type.
There was a problem hiding this comment.
➡️ I updated the code to include more complete descriptions. The user facing messages still have descriptions as well.
sharwell
force-pushed
the
non-copyable-field
branch
from
ca4b4cb
to
14703b1
Compare
Codecov Report
@@ Coverage Diff @@
## master #4798 +/- ##
==========================================
- Coverage 95.69% 95.68% -0.02%
==========================================
Files 1197 1197
Lines 271784 272061 +277
Branches 16433 16439 +6
==========================================
+ Hits 260082 260309 +227
- Misses 9599 9623 +24
- Partials 2103 2129 +26 |
