Fix for CA2000 not detected if nameof() is in the scope #3309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… including a test.
|
|
tompazourek
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3309 +/- ##
=======================================
Coverage 95.24% 95.24%
=======================================
Files 979 979
Lines 221697 221730 +33
Branches 14233 14235 +2
=======================================
+ Hits 211148 211181 +33
Misses 8927 8927
Partials 1622 1622 |
mavasani
approved these changes
Feb 26, 2020
|
Tagging @333fred - the workaround looks fine to me, but I think we want to fix the IOperation tree for |
|
@tompazourek Thanks for the contribution! |
|
Filed dotnet/roslyn#41963 for the underlying IOperation issue with nameof expressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3297
Basically any scope that contains a
nameofoperator will be ignored by the CA2000:DisposeObjectsBeforeLosingScope rule. And, in my opinion,nameofis used quite often (parameter checks, exception messages, logging, etc.), so it's quite a serious bug.This bug was introduced by #2704 (workaround for issue #2703), see also: dotnet/roslyn#32100. The contents of the
nameofexpression are anOperationKind.None, which is why the hack breaks it. I added additional check forINameOfOperationspecifically.