Flagging Json.NET JsonSerializer deserialization with insecure configuration #2687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
LLLXXXCCC
reviewed
Jul 26, 2019
...icrosoft.NetCore.Analyzers/Core/Security/DoNotUseInsecureDeserializerJsonNetWithoutBinder.cs
Outdated
Show resolved
Hide resolved
LLLXXXCCC
reviewed
Jul 26, 2019
src/Microsoft.NetCore.Analyzers/Core/MicrosoftNetCoreAnalyzersResources.resx
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jul 26, 2019
...icrosoft.NetCore.Analyzers/Core/Security/DoNotUseInsecureDeserializerJsonNetWithoutBinder.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jul 26, 2019
...icrosoft.NetCore.Analyzers/Core/Security/DoNotUseInsecureDeserializerJsonNetWithoutBinder.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jul 26, 2019
...icrosoft.NetCore.Analyzers/Core/Security/DoNotUseInsecureDeserializerJsonNetWithoutBinder.cs
Show resolved
Hide resolved
mavasani
reviewed
Jul 29, 2019
...icrosoft.NetCore.Analyzers/Core/Security/DoNotUseInsecureDeserializerJsonNetWithoutBinder.cs
Show resolved
Hide resolved
mavasani
reviewed
Jul 29, 2019
...etCore.Analyzers/UnitTests/Security/DoNotUseInsecureDeserializerJsonNetWithoutBinderTests.cs
Show resolved
Hide resolved
mavasani
reviewed
Jul 29, 2019
| @@ -0,0 +1,54 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <CodeSnippets xmlns="http://schemas.microsoft.com/VisualStudio/2005/CodeSnippet"> | |||
There was a problem hiding this comment.
@dotpaul I will ask you how to use this snippet next time we meet in person :)
Author
There was a problem hiding this comment.
https://docs.microsoft.com/visualstudio/ide/walkthrough-creating-a-code-snippet
This Visual Studio thing is pretty neat!
mavasani
approved these changes
Jul 29, 2019
Author
|
Thank you @mavasani ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.