Fix the bug that when delegate is used there will be a KeyNotFoundException. #2686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotpaul
reviewed
Jul 19, 2019
| results.Add(methodSymbol, new HashSet<ISymbol>()); | ||
| Debug.Assert(callGraph.Keys.Contains(methodSymbol), methodSymbol.Name + "was not present in the dictionary."); | ||
|
|
||
| foreach (var child in callGraph[methodSymbol].Keys) |
There was a problem hiding this comment.
Instead of just a Debug.Assert(), we could also gracefully handle missing keys in retail builds.
if (!callGraph.TryGetValue(methodSymbol, out var calledMethods))
{
Debug.Fail(methodSymbol.Name + " was not found in callGraph");
return;
}
foreach (var child in calledMethods.Keys)
dotpaul
reviewed
Jul 19, 2019
| results[methodSymbol].UnionWith(results[child]); | ||
| } | ||
| FindCalledDangerousMethod(child, visited, results); | ||
| Debug.Assert(results.Keys.Contains(child), child.Name + "was not present in the dictionary."); |
There was a problem hiding this comment.
Debug.Assert(results.Keys.Contains(child), child.Name + "was not present in the dictionary."); [](start = 32, length = 94)
Same thing here.
dotpaul
reviewed
Jul 22, 2019
| return; | ||
| } | ||
|
|
||
| results[methodSymbol].UnionWith(result); |
There was a problem hiding this comment.
I think here, instead of returning, you could just ignore that particular child if it's not found:
if (results.TryGetValue(child, out var result))
{
results[methodSymbol].UnionWith(result);
}
else
{
Debug.Fail(child.Name + " was not found in callGraph");
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.