fix: OfType now accepts a collection of object? #1617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the nature of your contribution?
Bugfix
When using
OfType<T>
on anIAsyncEnumerable<T?>
the compiler raised CS8620 warning:The warning appeared in the unit test I've added, before I've changed
OfType
declaration.The expected behavior is that the compiler doesn't raise a warning, because we're explicitly asking for our collection to be filtered for not-null objects (null has no type in terms of type checks).
The fix is to change the nullability of type parameter for extension method receiver (
this IAsyncEnumerable<object>
) to be nullable (object?
) instead.This PR fixes #1525, which was the original report of the above issue.