Remove EA.RazorCompiler reference
#9649
Conversation
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
No tooling changes I can see 👍
| } | ||
|
|
||
| [Fact(Skip = "Host outputs disabled - https://github.com/dotnet/razor/issues/8400")] | ||
| public async Task SourceGenerator_RazorFiles_DesignTime() |
There was a problem hiding this comment.
Why are we deleting these tests? I get that we're going to switch to reflection, but we still want the underlying functionality, right?
There was a problem hiding this comment.
This code's been disabled since we renamed the DLLs. It seems like it's going to remain off until the tooling team fixes the in process loading code and that wont' land until very late 17.9. As such we thought just delete the behavior entirely for 17.9 and bring back in 17.10 once we're in same process, the EA DLL saga is behind us and we're ready to move forward with actuallyusing this.
There was a problem hiding this comment.
The code cannot stay since the reference is removed, so it doesn't compile (even the test uses the EA DLL to verify the expected host outputs). When we want to bring back the test, we can dig it from Git history.
ghost
added this to the
5 participants
Part of dotnet/roslyn#71024.
Mostly reverts: