Skip to content

Conversation

@333fred
Copy link
Member

@333fred 333fred commented Jul 28, 2023

There are a few simple IDE scenarios that are using GetEditHandler that do no need to do so. This removes them in preparation for turning off calculations entirely.

There are a few simple IDE scenarios that are using GetEditHandler that do no need to do so. This removes them in preparation for turning off calculations entirely.
@333fred 333fred requested a review from a team as a code owner July 28, 2023 22:59
BlockSpan = blockSpan;
SpanKind = spanKind;
BlockKind = blockKind;
AcceptedCharacters = acceptedCharacters;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetEditHandler is the source of this information, which is why I'm removing it here. It appears entirely used.

Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@333fred 333fred merged commit 077d686 into dotnet:main Jul 29, 2023
@ghost ghost added this to the Next milestone Jul 29, 2023
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
@333fred 333fred deleted the remove-ide-edithandlerreferences branch March 6, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants