Skip to content

Move GenerateMethodCodeActionProvider to FindToken #8988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Move GenerateMethodCodeActionProvider to FindToken #8988

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0256250
Move GenerateMethodCodeActionProvider to FindToken
333fred Jul 20, 2023
b78c1fa
Move to a stronger assert about not null.
333fred Jul 25, 2023
3fe8455
Unnecessary using
333fred Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions ...oft.AspNetCore.Razor.LanguageServer/CodeActions/Razor/GenerateMethodCodeActionProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
using System.Threading.Tasks;
using Microsoft.AspNetCore.Razor.Language;
using Microsoft.AspNetCore.Razor.Language.Extensions;
using Microsoft.AspNetCore.Razor.Language.Legacy;
using Microsoft.AspNetCore.Razor.Language.Syntax;
using Microsoft.AspNetCore.Razor.LanguageServer.CodeActions.Models;
using Microsoft.CodeAnalysis;
Expand All @@ -29,13 +28,9 @@ internal class GenerateMethodCodeActionProvider : IRazorCodeActionProvider
return s_emptyResult;
}

var change = new SourceChange(context.Location.AbsoluteIndex, length: 0, newText: string.Empty);
var syntaxTree = context.CodeDocument.GetSyntaxTree();
var owner = syntaxTree.Root.LocateOwner(change);
if (owner is null)
{
return s_emptyResult;
}
var owner = syntaxTree.Root.FindToken(context.Location.AbsoluteIndex).Parent;
Assumes.NotNull(owner);

if (IsGenerateEventHandlerValid(owner, out var methodName, out var eventName))
{
Expand Down