Return ImmutableArray<T> in legacy RazorSyntaxTreeExtensions #8860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
approved these changes
Jun 22, 2023
333fred
approved these changes
Jun 22, 2023
Member
333fred
left a comment
333fred
left a comment
There was a problem hiding this comment.
Overall LGTM. Couple of small comments.
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorDocumentMappingService.cs
Outdated
Show resolved
Hide resolved
src/Compiler/Microsoft.AspNetCore.Razor.Language/src/ClassifiedSpanVisitor.cs
Outdated
Show resolved
Hide resolved
src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/ImmutableArrayExtensions.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I work on the legacy editor shim, I'm trying to pull bits of clean up and minor improvements into separate PRs.
ImmutableArray<T>.Builder.SetCapacityIfNeeded(...)extension method toSetCapacityIfLargerto match other similar extension methods.ItemCollection.TryGetValue<TKey, TValue>(...)method to clean up calling code.ImmutableArray<T>.Builder.DrainToImmutable()extension method.ImmutableArray<T>fromRazorSyntaxTreeExtensions.GetClassifiedSpans()andRazorSyntaxTreeExtensions.GetTagHelperSpans().ImmutableArray<T>.SelectAsArray(...)extension method.