Add spell checking endpoints #8851
Conversation
| return request.TextDocument; | ||
| } | ||
|
|
||
| public async Task<VSInternalSpellCheckableRangeReport[]> HandleRequestAsync(VSInternalDocumentSpellCheckableParams request, RazorRequestContext requestContext, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Is this supporting Streaming? Can we make sure we support streaming and send chunks of ranges to make sure we don't pass too large objects to the Client?
There was a problem hiding this comment.
This doesn't at the moment, and its a little problematic. There is a limitation in the platform that we can't stream results from our custom message target. We could in theory allow Roslyn to stream the results, and collect the chunks in that target, but we'd have to send all of Roslyns results over to here in one go. Similarly we need to have all of Roslyns results here in one chunk, because we need to combine them with the Razor results, and being a delta based API, everything has to be in order.
We could in theory, once we've done all of the work, send the results back to the client in chunks from here, but I'm not sure that alone is worth it.
allisonchou
left a comment
allisonchou
left a comment
There was a problem hiding this comment.
LGTM! Spell checker responses look very semantic tokens-esque 😊
...Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/SpellCheck/DocumentSpellCheckEndpoint.cs
Outdated
Show resolved
Hide resolved
| var ranges = response?.First().Ranges; | ||
| Assert.NotNull(ranges); | ||
|
|
||
| // To make for easier test failure analysis, we convert the ranges back to the test input, so we can show a diff |
…heck/DocumentSpellCheckEndpoint.cs Co-authored-by: Allison Chou <[email protected]>
3 participants
FYI @veler