Bump Roslyn version for integration test fix #8835
Conversation
allisonchou
changed the title
| var vsCompletionList = Assert.IsType<OptimizedVSCompletionList>(result.Value.Value); | ||
| var item = vsCompletionList.Items.First(); | ||
| Assert.Equal("DateTime", item.Label); | ||
| var item = vsCompletionList.Items.Where(item => item.Label == "DateTime"); |
There was a problem hiding this comment.
I'm not sure why the ordering of C# completion items changed, but it doesn't affect the end result in practice since the client seems to sort the items afterwards
There was a problem hiding this comment.
Isn't the problem that we're getting an unfiltered completion list instead of one filtered to DateTime?
There was a problem hiding this comment.
Oh, it is ordering things differently. I bet it's just a change in Roslyn.
...r/src/Microsoft.AspNetCore.Razor.LanguageServer/Semantic/Models/RazorSemanticTokensLegend.cs
Show resolved
Hide resolved
...Studio.RazorExtension.Dependencies/Microsoft.VisualStudio.RazorExtension.Dependencies.csproj
Outdated
Show resolved
Hide resolved
...Studio.RazorExtension.Dependencies/Microsoft.VisualStudio.RazorExtension.Dependencies.csproj
Outdated
Show resolved
Hide resolved
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
We shouldn't be reverting the semantic token work. The Protocol bump is all that's needed to fix that.
|
@DustinCampbell just pinged you offline, but the Protocol bump was already present in this PR beforehand and even with it, we were still seeing issues with hanging CI. We might need to still revert the semantic tokens work for now |
DustinCampbell
dismissed
their stale review
The plan is to use this PR, but we're going to get it cleaned up first.
This PR bumps our Roslyn version to take a logging fix for integration tests (dotnet/roslyn#68619). Bumping the Roslyn version resulted in us also needing to bump our
LanguageServer.Protocolversion, which introduces a new breaking type (InsertReplaceEdit). We should handle this type in a follow-up PR, however it doesn't seem to be urgent since neither the VS or VS Code clients support it yet.