Don't show assert dialog UI during test runs #8816
Conversation
| } | ||
| } | ||
|
|
||
| public override void Fail(string? message, string? detailMessage) |
There was a problem hiding this comment.
From my understanding, a single test will fail with this exception now instead of hanging the machine right?
There was a problem hiding this comment.
The DefaultTraceListener is responsible for displaying the assert dialog UI when a Debug.Assert or Debug.Fail triggers a failure. This would change such failures to throw an exception. That might fail the test, but only if the exception isn't caught before xUnit sees it.
There was a problem hiding this comment.
Actually, I'll do this a bit differently. The DefaultTraceListener has some useful behavior too, since it controls Debug.Write(...) as well. I'm thinking that I'll leave it in place but disable the assertion UI.
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
Love that this will still throw an exception and possibly fail a test. From the convo on teams I was worried it would just gloss over the asserts, but I would much rather know about them and validate.
|
I'm going to go ahead and merge this to help others PRs make progress in CI. |
3 participants
This change sets
DefaultTraceListener.AssertUiEnabledto false during test runs to avoid displaying assert dialogs, which can hang CI machines. To ensure that we continue seeing assertions fail during debug tests (just without UI) a newThrowingTraceListenerhas been added.