Skip to content

Conversation

@oleksandr-didyk
Copy link
Contributor

Contributes to dotnet/source-build#3435

Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter SourceBuild* files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see dotnet/source-build#3435 (comment))

Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, but might I also suggest adding the appropriate lines to the CODEOWNERS file, so we don't have to rely on humans reading comments. Humans tend to be unreliable 😁

@333fred
Copy link
Member

333fred commented Jun 1, 2023

Yes, please use the CODEOWNERS file for this purpose.

@oleksandr-didyk
Copy link
Contributor Author

Yes, please use the CODEOWNERS file for this purpose.

Initially wanted to add both the comment and the CODEOWNERS entry, but for a team to be added as a code owner it needs to have write permissions to the repo and I wanted to verify first if this is something we would need. I should've mentioned that in the description though, my bad, forgot to edit it.

If you are OK with granting write permissions to dotnet/source-build-internal, I will add the CODEOWNERS entry.

@333fred
Copy link
Member

333fred commented Jun 2, 2023

I'll ask in our teams channel for thoughts.

@oleksandr-didyk
Copy link
Contributor Author

@333fred soft ping - are there any updates regarding the write access? Thank you!

@jaredpar
Copy link
Member

Should be added now

@333fred
Copy link
Member

333fred commented Jun 12, 2023

@oleksandr-didyk you should have write access now.

@oleksandr-didyk
Copy link
Contributor Author

@oleksandr-didyk you should have write access now.

Thank you! I added the CODEOWNERS entry

@oleksandr-didyk oleksandr-didyk force-pushed the add-sb-review-comment branch from 537c2cd to 33fd2d9 Compare June 13, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants