-
Notifications
You must be signed in to change notification settings - Fork 217
add review comment to sb files #8787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
davidwengier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me, but might I also suggest adding the appropriate lines to the CODEOWNERS file, so we don't have to rely on humans reading comments. Humans tend to be unreliable 😁
|
Yes, please use the CODEOWNERS file for this purpose. |
Initially wanted to add both the comment and the If you are OK with granting write permissions to |
|
I'll ask in our teams channel for thoughts. |
|
@333fred soft ping - are there any updates regarding the write access? Thank you! |
|
Should be added now |
|
@oleksandr-didyk you should have write access now. |
Thank you! I added the |
537c2cd to
33fd2d9
Compare
Contributes to dotnet/source-build#3435
Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter
SourceBuild*files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see dotnet/source-build#3435 (comment))