-
Notifications
You must be signed in to change notification settings - Fork 225
Add missing compiler tests and dependency projects to the solution filter #8784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
da9fea2 to
a88923d
Compare
...ft.NET.Sdk.Razor.SourceGenerators.Tests/Microsoft.NET.Sdk.Razor.SourceGenerators.Test.csproj
Show resolved
Hide resolved
src/Compiler/Microsoft.NET.Sdk.Razor.SourceGenerators/RazorSourceGenerator.RazorProviders.cs
Outdated
Show resolved
Hide resolved
src/Compiler/Microsoft.AspNetCore.Razor.Language/src/RazorCodeGenerationOptions.cs
Show resolved
Hide resolved
|
@dotnet/razor-compiler for review. I would suggest commit-by-commit review for ease of understanding the changes. @dotnet/razor-tooling f43572a is the one commit that you really need to review. There isn't a shared test library between compiler and tooling, so I didn't add the testing utility reference to the tooling layer, but you should feel free to add it and start taking advantage of the diff helpers if you want. |
| #endregion | ||
|
|
||
| private class RazorCapabilitiesProvider : IRazorCapabilitiesProvider | ||
| private class RazorCapabilitiesProvider : IRazorTestCapabilitiesProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IRazorCapabilitiesProvider was marked obsolete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, noticed this change merged in last night, and was going to respond today :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out this breaks running tooling tests locall, so going to have to revert. We need to wait for these roslyn bits to be in a VS build.
EDIT: To be clear, I'll just revert this specific change to the RazorCapabilitiesProvider. The rest of the PR is fine :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, even reverting this, just having the new roslyn dep breaks running unit tests for me. I don't know what to think any more.
src/Compiler/Microsoft.NET.Sdk.Razor.SourceGenerators/RazorSourceGenerationOptions.cs
Show resolved
Hide resolved
...ft.NET.Sdk.Razor.SourceGenerators.Tests/Microsoft.NET.Sdk.Razor.SourceGenerators.Test.csproj
Show resolved
Hide resolved
...ompiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/RazorSourceGeneratorTestsBase.cs
Outdated
Show resolved
Hide resolved
|
Thanks everyone! |
We currently have an uglier way to acheive the same result: Line 410 in 450c0a1
I will try to make them nicer, but annoyingly, adding the reference to the CodeAnalysis.Testing package introduces some namespace collisions. |
No description provided.