Add a debug assert for faults at debug time #8768
Conversation
src/Razor/src/Microsoft.VisualStudio.Editor.Razor/TelemetryReporter.cs
Outdated
Show resolved
Hide resolved
|
If would be interesting if the integration test failures are caused by the assert. Nice to know we've possibly been muddying our own telemetry :D |
| await _initializedCompletionSource.Task.ConfigureAwait(false); | ||
| var result = await _jsonRpc.InvokeAsync<TResponse>(method, @params).ConfigureAwait(false); | ||
| var arguments = new object[] { @params! }; | ||
| var result = await _jsonRpc.InvokeWithCancellationAsync<TResponse>(method, arguments, cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
If would be interesting if the integration test failures are caused by the assert.
It was!!
This was a pain to track down, and reproing it is equally painful, but what I think is happening is that during integartion test startup, we're getting a diagnostics request that is subsequently cancelled by the editor. There is logic in CLaSP, however, that is allowing the task cancellation to bring the queue down because it is not the cancellation token it is expecting, so it assumes something terrible has happened.
This manifested as a razor/fault report once per integration test run, I suspect due to the nature of the integration test initialization, where we open a Razor file to verify everything is up and running, and then close it very quickly. In real world usage I never ran into any failures.
2 participants
To help see if we can track down the cause of https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1825424
Haven't had any hits on this today, from a quick run through a few things, so I don't think this will be annoying.
If you see this pop up, please debug and see why 😀