Move file to the misc workspace when it is deleted, if it is open #8759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
May 25, 2023
| _ => throw new NotImplementedException(), | ||
| }; | ||
| var message = formatter(state, exception); | ||
| if (message == "[null]" && exception is not null) |
Member
Author
There was a problem hiding this comment.
Snuck this one in, just because I saw it come up in the logs, and it wasn't exactly helpful. Not sure if its something on my machine, but whatever message formatter we're being passed here doesn't seem to use the exception at all.
lonitra
reviewed
May 25, 2023
...or/src/Microsoft.AspNetCore.Razor.LanguageServer/ProjectSystem/DefaultRazorProjectService.cs
Show resolved
Hide resolved
dibarbet
pushed a commit
to dibarbet/vscode-csharp
that referenced
this pull request
Jun 8, 2023
Goes with dotnet/razor#8759 to fix #1823464 Won't be merged until I can update it with a Razor bump. Essentially, when a file was deleted we were removing all our knowledge of the document, but with Green's delete behaviour, and VS Codes lazy `didClose` (and the fact that the file system exists) that could cause us to be in a bad state. We already have code in place that calls `removeDocument` when a document is closed, if it isn't in the workspace. Related work items: #1823464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1823464
We have file watchers, because we care about projects and things, and LSP has
didOpenanddidClosebecause LSP cares about documents. Sometimes these two things don't agree :)We were removing all of our knowledge of a document when the file is deleted, which makes sense at first glance, but there is no rule in LSP that says a file that is open has to exist in the physical realm. This change makes us move an open file to our Misc Files workspace, instead of forgetting about it, if its open.
Matches Roslyn behaviour here: https://github.com/dotnet/roslyn/blob/1119057b76330c6ec80b2a8c04c7fb4973d48773/src/Features/LanguageServer/Protocol/Workspaces/LspWorkspaceManager.cs#L251-L257