Clean up serialization layer and ProjectEngineHost #8758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
May 24, 2023
...osoft.AspNetCore.Razor.LanguageServer.Common/Extensions/JsonConverterCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
DustinCampbell
force-pushed
the
formalize-top-level-converters
branch
from
58c466b to
8795985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dotnet/razor-tooling: This is a big change but the vast majority of it is mechanical. I was focused on the following:
Only define JSON.NET JsonConverters for "top-level" types; that is, types that are serialized directly. There are only four of these:
ProjectRazorJson- we serialize/deserialize this directly to a file.ProjectSnapshotHandle- instances of this are passed as arguments over StreamJsonRpc to the Razor.Remote in the Roslyn OOP.TagHelperDeltaResultandTagHelperResolutionResult- these are results of calls to Razor.Remote in the Roslyn OOP.Reorganize MS.ANC.Razor.ProjectEngineHost and fixup namespaces.
Prefer
ImmutableArray<TagHelperDescriptor>over the many different variations that have been used to collect together tag helpers in the tooling layer --TagHelperDescriptor[],IReadOnlyList<TagHelperDescriptor>,IReadOnlyCollection<TagHelperDescriptor>, etc.These changes require a lot of updates to tests and calling code, which is largely mechanical.
@dotnet/razor-compiler: This is really a tooling change but there are two changes that have brought you to this PR. First, InternalsVisibleTo has been added for MS.VS.Razor.LiveShare.Tests. The other change is a new
SetCapacityIfNeededextension method inUtilities.Shared. Just letting you know in case you want to avoid wading through the whole PR.