Merge duplicate tag helper descriptors #8730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjonescz
commented
May 19, 2023
| if (root is CompilationUnitSyntax { Members: [NamespaceDeclarationSyntax { Members: [ClassDeclarationSyntax classSyntax, ..] }, ..] }) | ||
| { | ||
| var declaredClass = compilationWithDeclarations.GetSemanticModel(generatedDeclarationSyntaxTree).GetDeclaredSymbol(classSyntax, ct); | ||
| Debug.Assert(declaredClass is null || declaredClass is { AllInterfaces: [{ Name: "IComponent" }, ..] }); |
Member
Author
There was a problem hiding this comment.
Broken assert - a component does not have to inherit from IComponent, nothing stops users from declaring component like
@inherits objectThis manifested in the new test ComponentAndTagHelper where a component inherits from TagHelper.
| Scheme = "http" | ||
| }; | ||
| requestFeature.Headers.Host = "localhost"; | ||
| httpContext.Features.Set<IHttpRequestFeature>(requestFeature); |
Member
Author
There was a problem hiding this comment.
Small improvement of the test infra to allow rendering also Blazor components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #8721.
Fixes #8718.