-
Notifications
You must be signed in to change notification settings - Fork 226
Don't run integration tests on official builds #8617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run integration tests on official builds #8617
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
What was the reasoning on this? |
If you search for an email in your mailbox called "Proposed Validation matrix" you hopefully can refresh your memory, but I believe this is "the Roslyn way" |
|
Gotcha, thanks. Do we already have the daily integration test run leg that mentioned? I don't want to see this merged without that having been set up. |
|
We have had https://devdiv.visualstudio.com/DevDiv/_build?definitionId=15591&_a=summary for a long time. Did the email mention anything about the daily run needing to be green? 🙈 |
|
I'd say lets get that off the floor before merging this. |
|
@Cosifne fixed the integration tests 🎉🎉🎉 https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7792212&view=results 🎉🎉🎉 Will leave things for a week to make sure its stable, and then merge this. |
|
Does this skip tests on rolling builds generally? (i.e. the build that kicks off on the public queue after merging a PR.) I thought we still want to run tests for those. |
If I'm understanding you correctly, no, that would be this pipeline: https://devdiv.visualstudio.com/DevDiv/_build?definitionId=15591&_a=summary |
|
We resolved in the weekly tooling sync that we would review the rolling test pipeline, so I'm going to merge this. |
|
Thanks David! |
This has been discussed a few times, thought i'd have a crack at it.
@jaredpar PTAL
Fixes #8809