Skip to content

Conversation

@davidwengier
Copy link
Member

@davidwengier davidwengier commented Apr 20, 2023

This has been discussed a few times, thought i'd have a crack at it.

@jaredpar PTAL

Fixes #8809

@davidwengier davidwengier requested review from a team as code owners April 20, 2023 00:54
@davidwengier
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@333fred
Copy link
Member

333fred commented Apr 25, 2023

What was the reasoning on this?

@davidwengier
Copy link
Member Author

What was the reasoning on this?

If you search for an email in your mailbox called "Proposed Validation matrix" you hopefully can refresh your memory, but I believe this is "the Roslyn way"

@333fred
Copy link
Member

333fred commented Apr 25, 2023

Gotcha, thanks. Do we already have the daily integration test run leg that mentioned? I don't want to see this merged without that having been set up.

@davidwengier
Copy link
Member Author

We have had https://devdiv.visualstudio.com/DevDiv/_build?definitionId=15591&_a=summary for a long time. Did the email mention anything about the daily run needing to be green? 🙈

@333fred
Copy link
Member

333fred commented Apr 25, 2023

I'd say lets get that off the floor before merging this.

@davidwengier
Copy link
Member Author

@Cosifne fixed the integration tests 🎉🎉🎉 https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7792212&view=results 🎉🎉🎉

Will leave things for a week to make sure its stable, and then merge this.

@RikkiGibson
Copy link
Member

Does this skip tests on rolling builds generally? (i.e. the build that kicks off on the public queue after merging a PR.) I thought we still want to run tests for those.

@davidwengier
Copy link
Member Author

davidwengier commented Jun 6, 2023

i.e. the build that kicks off on the public queue after merging a PR

If I'm understanding you correctly, no, that would be this pipeline: https://devdiv.visualstudio.com/DevDiv/_build?definitionId=15591&_a=summary
That runs integration tests against main every 6 hours, from a different yaml file. We'd also still run them in PRs.

@davidwengier
Copy link
Member Author

We resolved in the weekly tooling sync that we would review the rolling test pipeline, so I'm going to merge this.

@davidwengier davidwengier merged commit 7fa73a5 into dotnet:main Jun 6, 2023
@davidwengier davidwengier deleted the IntegrationTestsInPRsOnly branch June 6, 2023 22:38
@RikkiGibson
Copy link
Member

Thanks David!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests should not run in official builds

5 participants