Skip to content

Fix darc publishing issues #8397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
allisonchou merged 1 commit into from
Mar 6, 2023
Merged

Fix darc publishing issues #8397

allisonchou merged 1 commit into from
Mar 6, 2023

Conversation

@allisonchou
Copy link
Contributor

@allisonchou allisonchou commented Mar 6, 2023

Summary of the changes

  • We're publishing duplicate blobs, which is breaking darc. We should only be publishing blobs on Windows.

@allisonchou allisonchou requested review from a team as code owners March 6, 2023 20:00
@allisonchou allisonchou mentioned this pull request Mar 6, 2023
Closed
RikkiGibson
RikkiGibson approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge at will :)

davidwengier
davidwengier approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@allisonchou allisonchou merged commit 78496c3 into main Mar 6, 2023
@allisonchou allisonchou deleted the allichou/FixDarcPublishing branch March 6, 2023 21:16
@RikkiGibson RikkiGibson mentioned this pull request Mar 6, 2023
Closed
@allisonchou allisonchou mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@allisonchou @davidwengier @RikkiGibson