Null annotate FirstAncestorOrSelf #8383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
sharwell
reviewed
Mar 3, 2023
| var csharp = owner.FirstAncestorOrSelf<CSharpCodeBlockSyntax>(); | ||
|
|
||
| return element.Body.Any(c => c is CSharpCodeBlockSyntax) || csharp is not null; | ||
| return element?.Body.Any(c => c is CSharpCodeBlockSyntax) ?? false || csharp is not null; |
Contributor
There was a problem hiding this comment.
💭 Is the ?? false necessary?
Suggested change
| return element?.Body.Any(c => c is CSharpCodeBlockSyntax) ?? false || csharp is not null; | |
| return element?.Body.Any(c => c is CSharpCodeBlockSyntax) ?? (csharp is not null); |
Member
Author
There was a problem hiding this comment.
Personally I find that confusing, and would have to spend a few minutes trying to understand the logic.
sharwell
reviewed
Mar 3, 2023
Comment on lines
257
to
+258
| var element = owner.FirstAncestorOrSelf<MarkupElementSyntax>(); | ||
| if (element is null) |
Contributor
There was a problem hiding this comment.
Suggested change
| var element = owner.FirstAncestorOrSelf<MarkupElementSyntax>(); | |
| if (element is null) | |
| if (owner.FirstAncestorOrSelf<MarkupElementSyntax>() is not { } element) |
allisonchou
approved these changes
Mar 4, 2023
Member
Author
|
Whoops! Sorry, hit merge from my phone without thinking about compiler reviews. @333fred let me know if you want me to revert, though its pretty minor. There are callers of the method in the compiler, but none of the callers are annotated anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1758057
Also should fix these faults:
https://prism.vsdata.io/failure/?query=fe%3Arazor%2Ffault&eventType=fault&failureType=hits&failureHash=9cfb44d6-ba55-60ab-9c03-17719a6d8c93
https://prism.vsdata.io/failure/?query=fe%3Arazor%2Ffault&eventType=fault&failureType=hits&failureHash=8ac6d32c-f098-a26d-a312-0abff8ff630c
https://prism.vsdata.io/failure/?query=fe%3Arazor%2Ffault&eventType=fault&failureType=hits&failureHash=53fd5f93-6e27-d7e7-85f7-b598754ccb70
https://prism.vsdata.io/failure/?query=fe%3Arazor%2Ffault&eventType=fault&failureType=hits&failureHash=eae8ed55-d35c-e440-a6d5-cd7094f88ab6