Disable targeting Windows for source-build #8376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is needed as part of the 8.0 Preview 3 release. |
jaredpar
approved these changes
Mar 2, 2023
333fred
approved these changes
Mar 2, 2023
Member
Author
|
Build is passing now. Ready to merge. |
jaredpar
pushed a commit
that referenced
this pull request
Mar 7, 2023
jaredpar
pushed a commit
that referenced
this pull request
Mar 7, 2023
Disable targeting Windows for source-build (#8376)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting of Windows was introduced by #8237. This causes Microsoft.WindowsDesktop.App.Ref prebuilts to be restored by source-build. We don't want to be loading Microsoft.WindowsDesktop.App.Ref when building .NET from source since it is for Linux.
cc @333fred