-
Notifications
You must be signed in to change notification settings - Fork 232
[main] Update dependencies from dotnet/arcade #8350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…227.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.22524.5 -> To Version 8.0.0-beta.23127.1
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approving dependency update.
|
Looks like it wants us to bump the analyzer versions. |
|
The way this target works, we're going to get a new warning every time the SDK updates <!-- Target to report a warning when SDK NetAnalyzers version is higher than the referenced NuGet NetAnalyzers version -->
<Target Name="_ReportUpgradeNetAnalyzersNuGetWarning" BeforeTargets="CoreCompile" Condition="'$(_SkipUpgradeNetAnalyzersNuGetWarning)' != 'true' ">
<Warning Text ="The .NET SDK has newer analyzers with version '$(_NETAnalyzersSDKAssemblyVersion)' than what version '$(_NETAnalyzersNuGetAssemblyVersion)' of 'Microsoft.CodeAnalysis.NetAnalyzers' package provides. Update or remove this package reference."
Condition="'$(_NETAnalyzersNuGetAssemblyVersion)' != '' AND
'$(_NETAnalyzersSDKAssemblyVersion)' != '' AND
$(_NETAnalyzersNuGetAssemblyVersion) < $(_NETAnalyzersSDKAssemblyVersion)"/>
</Target>Feel like we should just stop manually referencing this and take whatever the SDK is giving us. Is there a way to stop pinning the analyzers here and just use the default? Maybe just delete the package reference entirely. |
…228.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.22524.5 -> To Version 8.0.0-beta.23128.1
This fixes up the repo to handle the incoming arcade merge.
7123f54 to
35a2366
Compare
|
@dotnet/razor-compiler, @dotnet/razor-tooling PTAL at the following commit which is all the changes needed to get this arcade merge going green. Will add some context to the ones I feel are more questionable |
|
|
||
| # CA1305: Specify IFormatProvider | ||
| dotnet_diagnostic.CA1305.severity = warning | ||
| dotnet_diagnostic.CA1305.severity = none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is unnecessary since it's already set in the root editorconfig? But anyways, don't we want to have it enabled? At least eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's necessary though because this .editorconfig lists itself as a root so we don't actually consider the one above for files below.
|
Sigh ... looks like the tests are hanging on Windows now. Debugging. |
…301.4 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.22524.5 -> To Version 8.0.0-beta.23151.4
…302.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.22524.5 -> To Version 8.0.0-beta.23152.1
This pull request updates the following dependencies
From https://github.com/dotnet/arcade