Skip to content

Conversation

@jjonescz
Copy link
Member

@jjonescz jjonescz commented Feb 28, 2023

Fixes #7169.

The product change (d2ae625) is inspired by Razor Pages:

@class.Annotations[CommonAnnotations.NullableContext] = CommonAnnotations.NullableContext;

and MVC documents:

@class.Annotations[CommonAnnotations.NullableContext] = CommonAnnotations.NullableContext;

@jjonescz jjonescz force-pushed the 7169-BaseComponent-Nullable branch from e3fe792 to c19c43d Compare March 1, 2023 15:25
@jjonescz jjonescz marked this pull request as ready for review March 1, 2023 17:08
@jjonescz jjonescz requested review from a team as code owners March 1, 2023 17:08
@jjonescz jjonescz requested a review from 333fred March 3, 2023 08:59
@jaredpar jaredpar added the area-compiler Umbrella for all compiler issues label Mar 14, 2023
@jaredpar
Copy link
Member

This PR has gotten pretty stale. Is it a PR that we need to be acitvely pushing on? If not can we move it to draft?

@333fred
Copy link
Member

333fred commented Jul 11, 2023

Clarified with @jaredpar that we're waiting on his feedback on the breaking change. He'll give it some thought.

@jaredpar jaredpar added this to the 17.8 Planning milestone Jul 12, 2023
@jaredpar jaredpar modified the milestones: 17.8 Planning, 17.9 Planning Aug 7, 2023
@jjonescz
Copy link
Member Author

jjonescz commented Mar 1, 2024

@jaredpar ping :)

I ran our internal tests to verify there are no regressions in the projects we build there: https://dev.azure.com/dnceng/internal/_build/results?buildId=2391488&view=results

@jaredpar
Copy link
Member

jaredpar commented Mar 4, 2024

Sorry, I lost the thread here. Is this going to conflict with @chsienki upcoming FUSE changes. Both changes are doing massive baseline updates so curious if theyr'e going to conflict. If so need to figure out a merge order here.

@chsienki
Copy link
Member

chsienki commented Mar 4, 2024

For the most part, when it comes to baselines its not too much hassle to merge, you just re-generate them as part of the merge process so they include both sets of changes.

@jaredpar
Copy link
Member

jaredpar commented Mar 5, 2024

Sounds good. I'm on board with pushing this forward.

@jjonescz
Copy link
Member Author

jjonescz commented Mar 5, 2024

@dotnet/razor-compiler for reviews, thanks

@jjonescz jjonescz requested a review from 333fred March 6, 2024 12:56
@jjonescz
Copy link
Member Author

jjonescz commented Mar 6, 2024

@dotnet/razor-compiler for a second review - it's a simple change although "multiplied" by all our baselines :) thanks

@jjonescz jjonescz enabled auto-merge (squash) March 7, 2024 11:21
@jjonescz jjonescz merged commit 0806716 into dotnet:main Mar 7, 2024
@jjonescz jjonescz deleted the 7169-BaseComponent-Nullable branch March 7, 2024 12:16
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 17.10 Planning, Next Mar 7, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-compiler Umbrella for all compiler issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The auto-generated code for the Blazor components produces an unfixable warning when using @implements or @inherits with a nullable generic type

5 participants