-
Notifications
You must be signed in to change notification settings - Fork 230
Nullable enable Razor components #8348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e3fe792 to
c19c43d
Compare
...mpiler/Microsoft.AspNetCore.Razor.Language/src/Components/ComponentDocumentClassifierPass.cs
Show resolved
Hide resolved
|
This PR has gotten pretty stale. Is it a PR that we need to be acitvely pushing on? If not can we move it to draft? |
|
Clarified with @jaredpar that we're waiting on his feedback on the breaking change. He'll give it some thought. |
|
@jaredpar ping :) I ran our internal tests to verify there are no regressions in the projects we build there: https://dev.azure.com/dnceng/internal/_build/results?buildId=2391488&view=results |
|
Sorry, I lost the thread here. Is this going to conflict with @chsienki upcoming FUSE changes. Both changes are doing massive baseline updates so curious if theyr'e going to conflict. If so need to figure out a merge order here. |
|
For the most part, when it comes to baselines its not too much hassle to merge, you just re-generate them as part of the merge process so they include both sets of changes. |
|
Sounds good. I'm on board with pushing this forward. |
|
@dotnet/razor-compiler for reviews, thanks |
...Microsoft.AspNetCore.Razor.Language/test/IntegrationTests/ComponentCodeGenerationTestBase.cs
Outdated
Show resolved
Hide resolved
|
@dotnet/razor-compiler for a second review - it's a simple change although "multiplied" by all our baselines :) thanks |
Fixes #7169.
The product change (d2ae625) is inspired by Razor Pages:
razor/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions/src/RazorPageDocumentClassifierPass.cs
Line 96 in d7ad748
and MVC documents:
razor/src/Compiler/Microsoft.AspNetCore.Mvc.Razor.Extensions/src/MvcViewDocumentClassifierPass.cs
Line 70 in d7ad748