Skip to content

Re-enable some legacy extension tests #8327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjonescz merged 2 commits into from
Feb 25, 2023
Merged

Re-enable some legacy extension tests #8327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
875d7d0
Re-enable some legacy extension tests
jjonescz Feb 24, 2023
9123358
Update baselines
jjonescz Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...re.Mvc.Razor.Extensions.Version2_X/test/IntegrationTests/CodeGenerationIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ public void Basic_Runtime()
AssertCSharpDocumentMatchesBaseline(compiled.CodeDocument.GetCSharpDocument());
}

[Fact(Skip = "Reenable after CS1701 errors are resolved")]
[Fact]
public void Sections_Runtime()
{
// Arrange
Expand Down Expand Up @@ -319,7 +319,7 @@ public void Model_Runtime()
AssertCSharpDocumentMatchesBaseline(compiled.CodeDocument.GetCSharpDocument());
}

[Fact(Skip = "Reenable after CS1701 errors are resolved")]
[Fact]
public void ModelExpressionTagHelper_Runtime()
{
// Arrange
Expand All @@ -342,7 +342,7 @@ public class InputTestTagHelper : {typeof(TagHelper).FullName}
AssertCSharpDocumentMatchesBaseline(compiled.CodeDocument.GetCSharpDocument());
}

[Fact(Skip = "Reenable after CS1701 errors are resolved")]
[Fact]
public void RazorPages_Runtime()
{
// Arrange
Expand Down Expand Up @@ -377,7 +377,7 @@ public void RazorPagesWithRouteTemplate_Runtime()
AssertCSharpDocumentMatchesBaseline(compiled.CodeDocument.GetCSharpDocument());
}

[Fact(Skip = "Reenable after CS1701 errors are resolved")]
[Fact]
public void RazorPagesWithoutModel_Runtime()
{
// Arrange
Expand Down Expand Up @@ -426,7 +426,7 @@ public void ViewWithNamespace_Runtime()
AssertCSharpDocumentMatchesBaseline(compiled.CodeDocument.GetCSharpDocument());
}

[Fact(Skip = "Reenable after CS1701 errors are resolved")]
[Fact]
public void ViewComponentTagHelper_Runtime()
{
// Arrange
Expand Down
12 changes: 6 additions & 6 deletions ...es/IntegrationTests/CodeGenerationIntegrationTest/ModelExpressionTagHelper_Runtime.ir.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@
CSharpCode -
IntermediateToken - - CSharp - BeginContext(17, 2, true);
HtmlContent - (17:1,0 [2] ModelExpressionTagHelper.cshtml)
IntermediateToken - (17:1,0 [2] ModelExpressionTagHelper.cshtml) - Html - \n
LazyIntermediateToken - (17:1,0 [2] ModelExpressionTagHelper.cshtml) - Html - \n
CSharpCode -
IntermediateToken - - CSharp - EndContext();
CSharpCode -
IntermediateToken - - CSharp - BeginContext(64, 2, true);
HtmlContent - (64:3,0 [2] ModelExpressionTagHelper.cshtml)
IntermediateToken - (64:3,0 [2] ModelExpressionTagHelper.cshtml) - Html - \n
LazyIntermediateToken - (64:3,0 [2] ModelExpressionTagHelper.cshtml) - Html - \n
CSharpCode -
IntermediateToken - - CSharp - EndContext();
CSharpCode -
Expand All @@ -36,15 +36,15 @@
CSharpExpression -
IntermediateToken - - CSharp - ModelExpressionProvider.CreateModelExpression(ViewData, __model =>
IntermediateToken - - CSharp - __model.
IntermediateToken - (83:4,17 [4] ModelExpressionTagHelper.cshtml) - CSharp - Date
LazyIntermediateToken - (83:4,17 [4] ModelExpressionTagHelper.cshtml) - CSharp - Date
IntermediateToken - - CSharp - )
DefaultTagHelperExecute -
CSharpCode -
IntermediateToken - - CSharp - EndContext();
CSharpCode -
IntermediateToken - - CSharp - BeginContext(91, 2, true);
HtmlContent - (91:4,25 [2] ModelExpressionTagHelper.cshtml)
IntermediateToken - (91:4,25 [2] ModelExpressionTagHelper.cshtml) - Html - \n
LazyIntermediateToken - (91:4,25 [2] ModelExpressionTagHelper.cshtml) - Html - \n
CSharpCode -
IntermediateToken - - CSharp - EndContext();
CSharpCode -
Expand All @@ -55,15 +55,15 @@
DefaultTagHelperProperty - (110:5,17 [6] ModelExpressionTagHelper.cshtml) - for - Microsoft.AspNetCore.Mvc.ViewFeatures.ModelExpression InputTestTagHelper.For - HtmlAttributeValueStyle.DoubleQuotes
CSharpExpression -
IntermediateToken - - CSharp - ModelExpressionProvider.CreateModelExpression(ViewData, __model =>
IntermediateToken - (111:5,18 [5] ModelExpressionTagHelper.cshtml) - CSharp - Model
LazyIntermediateToken - (111:5,18 [5] ModelExpressionTagHelper.cshtml) - CSharp - Model
IntermediateToken - - CSharp - )
DefaultTagHelperExecute -
CSharpCode -
IntermediateToken - - CSharp - EndContext();
CSharpCode -
IntermediateToken - - CSharp - BeginContext(120, 2, true);
HtmlContent - (120:5,27 [2] ModelExpressionTagHelper.cshtml)
IntermediateToken - (120:5,27 [2] ModelExpressionTagHelper.cshtml) - Html - \n
LazyIntermediateToken - (120:5,27 [2] ModelExpressionTagHelper.cshtml) - Html - \n
CSharpCode -
IntermediateToken - - CSharp - EndContext();
Inject -
Expand Down
Loading