Skip to content

Conversation

@jjonescz
Copy link
Member

Separated from #8314.

@jjonescz jjonescz requested a review from sharwell February 24, 2023 14:08
@sharwell sharwell force-pushed the 7091-Object-wo-global branch from 38e8bef to 83f074e Compare February 24, 2023 15:10
@sharwell
Copy link
Contributor

I found a few files which were incorrectly updated (BOM added, which is generally good, but in this case was unrelated to the change above). I amended the baseline update commit to remove these changes.

@sharwell sharwell marked this pull request as ready for review February 24, 2023 15:25
@sharwell sharwell requested a review from a team as a code owner February 24, 2023 15:25
Copy link
Contributor

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed all files offline

Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/razor-compiler for a second review.

@sharwell sharwell merged commit c6a13b3 into dotnet:main Feb 28, 2023
@jjonescz jjonescz deleted the 7091-Object-wo-global branch March 1, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants