Fix UTF-8 BOM settings #8248
Merged
Fix UTF-8 BOM settings #8248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
approved these changes
Feb 9, 2023
333fred
reviewed
Feb 9, 2023
| [*.{cs,csx,vb,vbx}] | ||
| indent_size = 4 | ||
| insert_final_newline = true | ||
| encoding = utf-8-bom |
Member
There was a problem hiding this comment.
I copied this from roslyn, so it's likely busted over there too: https://github.com/dotnet/roslyn/blob/main/.editorconfig#L15
Member
Author
There was a problem hiding this comment.
No, I checked, Roslyn has charset correctly. encoding was wrong in Razor.
Member
There was a problem hiding this comment.
It looks like the link you provided to Roslyn is already correct in main.
Member
There was a problem hiding this comment.
I swear to god it showed encoding on my screen 5 seconds ago...
333fred
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #8099.
Tested locally with Visual Studio.