Skip to content

Don't NotImplemented in OutputwindowLogger #8233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

Don't NotImplemented in OutputwindowLogger #8233

merged 1 commit into from
Feb 6, 2023

Conversation

@ryanbrandenburg
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg commented Feb 6, 2023

Summary of the changes

  • It was silly of me to make this an exception just because we weren't using scopes at the time, especially given that apparently we already had a pattern to do this without the underlying stores having to understand (NoOps).

@ryanbrandenburg ryanbrandenburg requested a review from a team as a code owner February 6, 2023 18:21
@ryanbrandenburg ryanbrandenburg mentioned this pull request Feb 6, 2023
Merged
@ryanbrandenburg ryanbrandenburg merged commit 3a3e25d into dotnet:main Feb 6, 2023
@ryanbrandenburg ryanbrandenburg deleted the OutputWindowScope branch February 6, 2023 23:02
@allisonchou allisonchou mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryanbrandenburg @davidwengier