Skip to content

Conversation

@DustinCampbell
Copy link
Member

This is a follow up to #8099 to remove the BOM from out batch files to allow them to run properly.

@333fred
Copy link
Member

333fred commented Jan 10, 2023

@DustinCampbell is our CI not exercising these files?

@DustinCampbell
Copy link
Member Author

@DustinCampbell is our CI not exercising these files?

Nope. These are for regular development.

@DustinCampbell
Copy link
Member Author

@333fred: It looks like your PR also added a BOM to eng/CIBuild.cmd, which is exercised by CI. I'm not sure why I'm not seeing some sort of warning from running that in CI though. It might be getting eaten.

@DustinCampbell DustinCampbell force-pushed the remove-bom-from-batch-files branch from 7a9df79 to b8f5d42 Compare January 10, 2023 18:45
@DustinCampbell DustinCampbell merged commit 0979102 into dotnet:main Jan 10, 2023
@DustinCampbell DustinCampbell deleted the remove-bom-from-batch-files branch January 10, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants