Skip to content

Mop up a few remaining feedback items from #13016#13045

Merged
chsienki merged 1 commit into
dotnet:mainfrom
chsienki:fix/warning-waves-feedback
Apr 14, 2026
Merged

Mop up a few remaining feedback items from #13016#13045
chsienki merged 1 commit into
dotnet:mainfrom
chsienki:fix/warning-waves-feedback

Conversation

@chsienki

@chsienki chsienki commented Apr 13, 2026

Copy link
Copy Markdown
Member

Address remaining review feedback from the warning waves PR (#13016):

  • Revert GetDiagnostics to PooledArrayBuilder approach for better performance in high-traffic path
  • Fix DebuggerToString to use multiline raw interpolated string matching original format

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@chsienki
chsienki requested a review from a team as a code owner April 13, 2026 20:42
@chsienki

Copy link
Copy Markdown
Member Author

@ToddGrun for review, just a couple of items from the WarningWave that you commented on that I missed.

@ToddGrun ToddGrun left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants