Skip to content

Make IntermediateNodeCollection implement IReadOnlyList<IntermediateNode> #13006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chsienki merged 2 commits into from
Apr 3, 2026
Merged

Make IntermediateNodeCollection implement IReadOnlyList<IntermediateNode> #13006

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5516760
Initial plan
Copilot Apr 3, 2026
e663091
Make IntermediateNodeCollection implement IReadOnlyList<IntermediateN…
Copilot Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...osoft.CodeAnalysis.Razor.Compiler/src/Language/Intermediate/IntermediateNodeCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace Microsoft.AspNetCore.Razor.Language.Intermediate;

public sealed class IntermediateNodeCollection : IList<IntermediateNode>
public sealed class IntermediateNodeCollection : IList<IntermediateNode>, IReadOnlyList<IntermediateNode>

@ToddGrun ToddGrun Apr 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there some places we can change to take advantage of this, or is that coming later?

@chsienki chsienki Apr 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah there are places. It'll be a follow up just because of the way I broke up the github issues.

{
public static readonly IntermediateNodeCollection ReadOnly = new IntermediateNodeCollection(new List<IntermediateNode>().AsReadOnly());

Expand Down
Loading