Conversation
…n method. The ToString implementation is the standard way to get a piece of text from a SourceText. This is likely a perf improvement on net core (not adding potentially large arrays to a pool), and likely a perf wash on net std (the ToString call does an extra copy of the data, but again won't add large arrays to a pool)
davidwengier
approved these changes
Jan 8, 2026
ToddGrun
deleted the
dev/toddgrun/Remove_SourceText.GetSubTextString_ExtensionMethod
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SourceText.ToString implementation is the standard way to get a piece of text from a SourceText. Switching code to use SourceText.ToString instead of our GetSubTextString extension method is likely a perf improvement on net core (not adding potentially large arrays to a pool), and likely a perf wash on net std (the ToString call does an extra copy of the data, but again won't add large arrays to a pool)
This is the fallout from a comment in a recent PR noticing that we were using ToString/GetSubTextString interchangeably throughout the codebase.