Create cohosting tests for existing LSP server endpoint test coverage#12630
Merged
davidwengier merged 14 commits intodotnet:mainfrom Jan 5, 2026
Merged
Create cohosting tests for existing LSP server endpoint test coverage#12630davidwengier merged 14 commits intodotnet:mainfrom
davidwengier merged 14 commits intodotnet:mainfrom
Conversation
Contributor
|
Admittedly, I skimmed most of this, but what I saw looked great! |
This was referenced Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was starting to play with removing the cohosting feature flag, and very quickly got to a point where the old LSP server endpoint tests stopped running, and in some cases even compiling, which would mean needing to delete them. Before we do that, I wanted to make sure we had identified any gaps in the coverage of the equivalent cohosting endpoint tests.
I tried to get copilot planning mode to create a todo list for this, hoping to then be able to assign it tasks and have it create tests etc. but it didn't work, and it's been pretty quiet while you've all been on vacation anyway, so I did this the old fashioned way :)
Should be all test only changes, and each commit is a different feature area.