Bring back Go to Def, FAR and hover for components via Roslyn#12501
Merged
davidwengier merged 8 commits intodotnet:mainfrom Nov 19, 2025
Merged
Bring back Go to Def, FAR and hover for components via Roslyn#12501davidwengier merged 8 commits intodotnet:mainfrom
davidwengier merged 8 commits intodotnet:mainfrom
Conversation
Guess IVTs have changed since this was written
…rectives this time
Note: No .cs file changes. Win!
davidwengier
commented
Nov 18, 2025
| var offset = nonGenericTypeName.Span.StartsWith('@') | ||
| ? 1 | ||
| : 0; | ||
| context.AddSourceMappingFor(node.StartTagSpan, offset); |
Member
Author
There was a problem hiding this comment.
This line is the only one that is different from #12287. In that PR, it was BuildEnhancedLinePragma:
chsienki
approved these changes
Nov 18, 2025
This was referenced Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12276 again
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2633418
Commit-at-a-time is thoroughly recommended.
Commits 1-4 expose a DocumentExcerpt service that Roslyn can use to provide nice results in FAR etc., because without the code-gen changes, the generated code is pretty ugly.
Commit 5 "reverts" #12486, bringing #12287 back but without any changes to the code-gen this time, just a new source mapping.
Commit 6 is test baseline updates (only source mappings, no .cs files)
Commit 7 removes the requirement for line pragmas to exactly match source mappings. I left the rest of the validation though
Commit 8 bumps us to a new Roslyn with the new document excerpt services.