Skip to content

Fix view component metadata serialization #12494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidwengier merged 1 commit into from
Nov 18, 2025
Merged

Fix view component metadata serialization #12494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Mvc/ViewComponentMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ internal ViewComponentMetadata(string name, TypeNameObject originalTypeNameObjec
public string Name { get; }
internal TypeNameObject OriginalTypeNameObject { get; }

public string OriginalTypeName => OriginalTypeNameObject.FullName.AssumeNotNull();
public string? OriginalTypeName => OriginalTypeNameObject.FullName;

internal override bool HasDefaultValue => false;

Expand All @@ -31,9 +31,9 @@ private protected override void BuildChecksum(in Checksum.Builder builder)
public ref struct Builder
{
public string? Name { get; set; }
internal TypeNameObject? OriginalTypeNameObject { get; set; }
internal TypeNameObject OriginalTypeNameObject { get; set; }

public readonly ViewComponentMetadata Build()
=> new(Name.AssumeNotNull(), OriginalTypeNameObject.AssumeNotNull());
=> new(Name.AssumeNotNull(), OriginalTypeNameObject);
}
}