Skip to content

Don't add newlines at the start of implicit expressions in on type formatting#12489

Merged
davidwengier merged 3 commits into
dotnet:mainfrom
davidwengier:OnTypeFormattingFix
Nov 19, 2025
Merged

Don't add newlines at the start of implicit expressions in on type formatting#12489
davidwengier merged 3 commits into
dotnet:mainfrom
davidwengier:OnTypeFormattingFix

Enable debug asserts in on type formatting tests

a0b00a6
Select commit
Loading
Failed to load commit list.
Azure Pipelines / razor-tooling-ci succeeded Nov 16, 2025 in 15m 41s

Build #20251115.1 had test failures

Details

Tests

  • Failed: 4 (0.00%)
  • Passed: 107,525 (99.55%)
  • Other: 483 (0.45%)
  • Total: 108,012

Annotations

Check failure on line 1 in FullyQualify

See this annotation in the file changed.

@azure-pipelines azure-pipelines / razor-tooling-ci

FullyQualify

Could not find code action with name 'FullyQualify'.\n\nAvailable:\n    
Raw output
   at Roslyn.Test.Utilities.AssertEx.NotNull[T](T object, String message)
   at Microsoft.VisualStudio.Razor.LanguageClient.Cohost.CodeActions.CohostCodeActionsEndpointTestBase.VerifyCodeActionRequestAsync(TextDocument document, TestCode input, String codeActionName, Int32 childActionIndex, Boolean expectOffer) in /_/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/CohostCodeActionsEndpointTestBase.cs:line 101
   at Microsoft.VisualStudio.Razor.LanguageClient.Cohost.CodeActions.CohostCodeActionsEndpointTestBase.VerifyCodeActionAsync(TestCode input, String expected, String codeActionName, Int32 childActionIndex, Nullable`1 fileKind, String documentFilePath, ValueTuple`2[] additionalFiles, ValueTuple`2[] additionalExpectedFiles, Boolean addDefaultImports) in /_/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/CohostCodeActionsEndpointTestBase.cs:line 46
   at Microsoft.VisualStudio.Razor.LanguageClient.Cohost.CodeActions.AddUsingTests.FullyQualify() in /_/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/AddUsingTests.cs:line 31
--- End of stack trace from previous location ---

Check failure on line 1 in AddUsing_Typo

See this annotation in the file changed.

@azure-pipelines azure-pipelines / razor-tooling-ci

AddUsing_Typo

Could not find code action with name 'AddImport'.\n\nAvailable:\n    
Raw output
   at Roslyn.Test.Utilities.AssertEx.NotNull[T](T object, String message)
   at Microsoft.VisualStudio.Razor.LanguageClient.Cohost.CodeActions.CohostCodeActionsEndpointTestBase.VerifyCodeActionRequestAsync(TextDocument document, TestCode input, String codeActionName, Int32 childActionIndex, Boolean expectOffer) in /_/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/CohostCodeActionsEndpointTestBase.cs:line 101
   at Microsoft.VisualStudio.Razor.LanguageClient.Cohost.CodeActions.CohostCodeActionsEndpointTestBase.VerifyCodeActionAsync(TestCode input, String expected, String codeActionName, Int32 childActionIndex, Nullable`1 fileKind, String documentFilePath, ValueTuple`2[] additionalFiles, ValueTuple`2[] additionalExpectedFiles, Boolean addDefaultImports) in /_/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/CohostCodeActionsEndpointTestBase.cs:line 46
   at Microsoft.VisualStudio.Razor.LanguageClient.Cohost.CodeActions.AddUsingTests.AddUsing_Typo() in /_/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/AddUsingTests.cs:line 105
--- End of stack trace from previous location ---

Check failure on line 1 in AddUsing_WithExisting

See this annotation in the file changed.

@azure-pipelines azure-pipelines / razor-tooling-ci

AddUsing_WithExisting

Could not find code action with name 'AddImport'.\n\nAvailable:\n    
Raw output
   at Roslyn.Test.Utilities.AssertEx.NotNull[T](T object, String message)
   at Microsoft.VisualStudio.Razor.LanguageClient.Cohost.CodeActions.CohostCodeActionsEndpointTestBase.VerifyCodeActionRequestAsync(TextDocument document, TestCode input, String codeActionName, Int32 childActionIndex, Boolean expectOffer) in /_/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/CohostCodeActionsEndpointTestBase.cs:line 101
   at Microsoft.VisualStudio.Razor.LanguageClient.Cohost.CodeActions.CohostCodeActionsEndpointTestBase.VerifyCodeActionAsync(TestCode input, String expected, String codeActionName, Int32 childActionIndex, Nullable`1 fileKind, String documentFilePath, ValueTuple`2[] additionalFiles, ValueTuple`2[] additionalExpectedFiles, Boolean addDefaultImports) in /_/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/CohostCodeActionsEndpointTestBase.cs:line 46
   at Microsoft.VisualStudio.Razor.LanguageClient.Cohost.CodeActions.AddUsingTests.AddUsing_WithExisting() in /_/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/AddUsingTests.cs:line 132
--- End of stack trace from previous location ---

Check failure on line 1 in AddUsing

See this annotation in the file changed.

@azure-pipelines azure-pipelines / razor-tooling-ci

AddUsing

Could not find code action with name 'AddImport'.\n\nAvailable:\n    
Raw output
   at Roslyn.Test.Utilities.AssertEx.NotNull[T](T object, String message)
   at Microsoft.VisualStudio.Razor.LanguageClient.Cohost.CodeActions.CohostCodeActionsEndpointTestBase.VerifyCodeActionRequestAsync(TextDocument document, TestCode input, String codeActionName, Int32 childActionIndex, Boolean expectOffer) in /_/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/CohostCodeActionsEndpointTestBase.cs:line 101
   at Microsoft.VisualStudio.Razor.LanguageClient.Cohost.CodeActions.CohostCodeActionsEndpointTestBase.VerifyCodeActionAsync(TestCode input, String expected, String codeActionName, Int32 childActionIndex, Nullable`1 fileKind, String documentFilePath, ValueTuple`2[] additionalFiles, ValueTuple`2[] additionalExpectedFiles, Boolean addDefaultImports) in /_/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/CohostCodeActionsEndpointTestBase.cs:line 46
   at Microsoft.VisualStudio.Razor.LanguageClient.Cohost.CodeActions.AddUsingTests.AddUsing() in /_/src/Razor/test/Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/CodeActions/AddUsingTests.cs:line 84
--- End of stack trace from previous location ---