Don't create a new FormattingContext if there weren't any cleanup changes#12400
Merged
ToddGrun merged 2 commits intodotnet:mainfrom Oct 27, 2025
Conversation
davidwengier
approved these changes
Oct 27, 2025
| context.Logger?.LogSourceText("AfterCleanupDocument", cleanedText); | ||
|
|
||
| changedContext = await changedContext.WithTextAsync(cleanedText, cancellationToken).ConfigureAwait(false); | ||
| if (!cleanupChanges.IsEmpty) |
Member
There was a problem hiding this comment.
Nit: Should probably move this a couple of lines higher, and just set cleanedText to formattedText if the changes are empty. There is no point calling WithChanges or logging the same content again.
Contributor
Author
There was a problem hiding this comment.
Done in commit 2. I did consider originally doing that, but the WithChanges call short circuits if the IA is empty and I wasn't certain whether we wanted the logging call to always happen.
This was referenced Oct 28, 2025
This was referenced Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormattingContext.WithTextAsync shows up as the major CPU time user during onTypeFormatting, mostly due to it's eventual call to GeneratorRunResult.CreateAsync. This change just avoids one of those calls when not necessary.