Normalize line endings in on type formatting#12398
Merged
davidwengier merged 6 commits intodotnet:mainfrom Oct 27, 2025
Merged
Conversation
ToddGrun
reviewed
Oct 27, 2025
...crosoft.AspNetCore.Razor.LanguageServer.Test/Formatting_NetFx/CodeDirectiveFormattingTest.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Oct 27, 2025
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Extensions/SourceTextExtensions.cs
Outdated
Show resolved
Hide resolved
This was referenced Oct 27, 2025
This was referenced Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12395
Fixes #10836
This just brings the fix from #10802 to on type formatting. I was surprised it was that easy, but I suspect the simplification due to only having one formatting engine might have helped. Extra evidence for this is that all of the other tests we had that skipped LF endings passed without any effort on my behalf really.